[Bug 35058] New: No contents displaying when an authority record is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Bug ID: 35058 Summary: No contents displaying when an authority record is saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I believe this has to do with our changes for tabs: When an authority record is edited and saved, you get directed to the authority detail page, but only the tabs themselves and no contents show. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34075 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34075 [Bug 34075] Allow specifying default tab view for authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157181&action=edit Bug 35058: Automatically show authority tab 0 if DefaultAuthorityTab is empty The change to the authority detail page made by Bug 34075 didn't take into account the possibility that the DefaultAuthorityTab tab preference might be empty. This leads to a JavaScript error and no tabs being shown. We can avoid this situation by initializing the tab_object variable as an empty object. To test, apply the patch and go to Authorities to repeat the test plan for Bug 34075: 1. Locate and view the detail page for an authority record. 2. The page should default to the 0XX or first tab. 3. Go to Administration -> System preferences and set the DefaultAuthorityTab preference to a number that won't be found in your authority record (e.g. there are no 3XX tags defined). 4. Return to the detail page and verify that the first tab is displayed. 5. Set DefaultAuthorityTab to 1XX or greater, one that exists in your record. 6. Reload the detail page and confirm the correct tab is selected. 7. Test the case where DefaultAuthorityTab is undefined by directly updating the database. In koha-testing-docker you can run this command: echo "update systempreferences set value = 3 where variable = 'DefaultAuthorityTab';" | koha-mysql kohadev Return to the authority detail tab to confirm that the first tab is displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157181|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157211&action=edit Bug 35058: Automatically show authority tab 0 if DefaultAuthorityTab is empty The change to the authority detail page made by Bug 34075 didn't take into account the possibility that the DefaultAuthorityTab tab preference might be empty. This leads to a JavaScript error and no tabs being shown. We can avoid this situation by initializing the tab_object variable as an empty object. To test, apply the patch and go to Authorities to repeat the test plan for Bug 34075: 1. Locate and view the detail page for an authority record. 2. The page should default to the 0XX or first tab. 3. Go to Administration -> System preferences and set the DefaultAuthorityTab preference to a number that won't be found in your authority record (e.g. there are no 3XX tags defined). 4. Return to the detail page and verify that the first tab is displayed. 5. Set DefaultAuthorityTab to 1XX or greater, one that exists in your record. 6. Reload the detail page and confirm the correct tab is selected. 7. Test the case where DefaultAuthorityTab is undefined by directly updating the database. In koha-testing-docker you can run this command: echo "update systempreferences set value = 3 where variable = 'DefaultAuthorityTab';" | koha-mysql kohadev Return to the authority detail tab to confirm that the first tab is displayed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Easy fix, going to PQA directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34075 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35058 Bug 35058 depends on bug 34075, which changed state. Bug 34075 Summary: Allow specifying default tab view for authorities https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34075 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org