[Bug 37424] New: Batch checkout silently fails if item contains materials specified (952$3)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Bug ID: 37424 Summary: Batch checkout silently fails if item contains materials specified (952$3) Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: catrina@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 169379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169379&action=edit Screenshot where the 952$3 should display As noted in 15718 and 23780, when using the batch checkout feature, there’s no preview of the 952$3 in the confirm checkout screen to let you know why the checkout needs confirmation, but also the checkout silently fails even when selecting "Checkout or renew". It sounded most similar to 30995, but my user has the force_checkout permission, so that doesn’t apply. Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. When you select “Checkout or renew,” you are taken back to the batch check out screen, but the item with the 952$3 is NOT checked out to the patron, nor are you given any warning that an error occurred. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169438&action=edit Bug 37424: Display additional materials note in batch checkout This patch adds a missing conditional for ADDITIONAL_MATERIALS to the batch checkout table Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. Do not confirm checkout 7. Apply patch 8. Try again, the materials note should show this time 9. Confirm checkout 10. Success! Item is checked out -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |37396 CC| |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37396 [Bug 37396] Batch checkout does not checkout items if OverduesBlockCirc set to Ask for Confirmation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169438|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169447&action=edit Bug 37424: Display additional materials note in batch checkout This patch adds a missing conditional for ADDITIONAL_MATERIALS to the batch checkout table Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. Do not confirm checkout 7. Apply patch 8. Try again, the materials note should show this time 9. Confirm checkout 10. Success! Item is checked out Signed-off-by: Catrina Berka <catrina@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi Catrina. It looks like you've signed this off. So that you get the credit on the dashboard (https://dashboard.koha-community.org/), could you update the status to "Signed off"? (It will also move the bug into the QA queue.) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169447|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174912&action=edit Bug 37424: Display additional materials note in batch checkout This patch adds a missing conditional for ADDITIONAL_MATERIALS to the batch checkout table Test plan: 1. Set a staff member with circ permissions, including FORCE_CHECKOUT 2. Turn on: CircConfirmItemParts, BatchCheckouts, BatchCheckoutsValidCategories (all) 3. Log in as staff member in step 1 4. Attempt to checkout an item with a 952$3 from the batch checkout tab 5. The item with a 952$3 displays, but the copy/text of the materials specified note does not. 6. Do not confirm checkout 7. Apply patch 8. Try again, the materials note should show this time 9. Confirm checkout 10. Success! Item is checked out Signed-off-by: Catrina Berka <catrina@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very small template change, will pick for 24.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the batch release notes| |checkout when and item has | |a 952$3 value (Materials | |specified (bound volume or | |other part)). The text for | |the 952$3 was not displayed | |on the batch check out | |screen, it would silently | |fail, and then not check | |out the item to the patron | |(with no warning given). | |(This requires setting | |these system preferences | |CircConfirmItemParts, | |BatchCheckouts, | |BatchCheckoutsValidCategori | |es (all).) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 37396 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the batch |This fixes the batch release notes|checkout when and item has |checkout when an item has a |a 952$3 value (Materials |952$3 value (Materials |specified (bound volume or |specified (bound volume or |other part)). The text for |other part)). The text for |the 952$3 was not displayed |the 952$3 was not displayed |on the batch check out |on the batch check out |screen, it would silently |screen, it would silently |fail, and then not check |fail, and then not check |out the item to the patron |out the item to the patron |(with no warning given). |(with no warning given). |(This requires setting |(This requires setting |these system preferences |these system preferences |CircConfirmItemParts, |CircConfirmItemParts, |BatchCheckouts, |BatchCheckouts, |BatchCheckoutsValidCategori |BatchCheckoutsValidCategori |es (all).) |es (all).) Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- This is a bug fix and no interface changes, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37424 Bug 37424 depends on bug 37396, which changed state. Bug 37396 Summary: Batch checkout does not checkout items if OverduesBlockCirc set to ask for confirmation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37396 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org