[Bug 29042] New: Improve formatting of entry form in Additional Contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Bug ID: 29042 Summary: Improve formatting of entry form in Additional Contents Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 24387 To fix a FIXME in the template: Add a "clearfix" class in the form markup so that the standard '<fieldset class="rows">' can be used. Also: Lengthen the title field and add a maxlength attribute to match the table column. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124939&action=edit Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124939|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 125403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125403&action=edit Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Almost sad to see this line removed :) <fieldset>[%# FIXME We should remove list-style:none; and use class="rows" here but it does not work. Owen please help! %]> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125403|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125655&action=edit Bug 29042: Improve formatting of entry form in Additional Contents This patch makes some corrections to the Additional Contents template so that the content entry form can be styled like other similar forms in the staff interface. The patch also updates the form's "title" field so that it is longer and has a maxlength attribute matching the size of the table column. To test, apply the patch and go to Tools -> News. - Create a new news item. - In the entry form, confirm that the "Title" and "Content" fields are styled consistently with other similar forms. - Confirm that the "title" field is longer. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Bug 29042 depends on bug 24387, which changed state. Bug 24387 Summary: Rename News tool https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29042 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org