[Bug 17969] New: Refactor the way <<items.content>> is generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Bug ID: 17969 Summary: Refactor the way <<items.content>> is generated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59414&action=edit Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 [Bug 17967] TT syntax for notices - Prove that ODUE is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59414|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 61637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61637&action=edit Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9083 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61637|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63976&action=edit Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17969: Refactor the way <<items.content>> is generated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63976|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65364&action=edit Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65364|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65567&action=edit Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65568&action=edit Bug 17969: (QA followup) Add POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65567|0 |1 is obsolete| | Attachment #65568|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65684&action=edit Bug 17969: Refactor the way <<items.content>> is generated <<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <<items.content>> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65685&action=edit Bug 17969: (QA followup) Add POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Patch complexity|--- |Small patch CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refactor the way |Refactor the way the |<<items.content>> is |items.content placeholder |generated |is generated CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- << >> in the title were not working well with the html version of the release notes. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org