[Bug 33214] New: Make sure cache is cleared properly (30744 follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Bug ID: 33214 Summary: Make sure cache is cleared properly (30744 follow-up) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org We are seeing some random failures in which the calculated AV values are not correct. It all points to cache: https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/consol... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |30744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 148132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148132&action=edit Bug 33214: Make tests use random data and clear the cache This trivial patch removes some wrongly hardcoded bits, and makes the tests also clear the cache before and after being run. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148132|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148134&action=edit Bug 33214: Make tests use random data and clear the cache This trivial patch removes some wrongly hardcoded bits, and makes the tests also clear the cache before and after being run. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 148143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148143&action=edit Bug 33214: (follow-up) Consistency on key names This patch makes GetAuthorisedValueDesc used cache keys match what we discussed on the bug, which seems to have been lost on some rebase and highlighted by failing tests. I also add some more cache flushes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 148144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148144&action=edit Bug 33214: (follow-up) Make tests less fragile Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #3)
Pushed to master for 22.11.
Oops, outdated config on the laptop! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30744 |30920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make sure cache is cleared |Make sure cache is cleared |properly (30744 follow-up) |properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for working through these Tomas, great spot on the rebase issue.. weird, that somehow crept in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Bug 33214 depends on bug 30920, which changed state. Bug 30920 Summary: Add caching to C4::Biblio::GetAuthorisedValueDesc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org