https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132350&action=edit Bug 30384: Reindent template for ordering from a MARC file This patch updates the template for ordering from a MARC file so that the indentation is consistent. This patch does not fix a couple of bugs which will be fixed in a later patch: The MARC modal window has the wrong width, and there is a Flatpickr error in the console. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that everything still works correctly: - Tabs work correctly - JavaScript controls (select all, show inactive, etc.) work - MARC and Card previews work - Adding orders works -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388 [Bug 30388] Fixe some errors in the template for ordering from a MARC file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132350|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 134658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134658&action=edit Bug 30384: Reindent template for ordering from a MARC file This patch updates the template for ordering from a MARC file so that the indentation is consistent. This patch does not fix a couple of bugs which will be fixed in a later patch: The MARC modal window has the wrong width, and there is a Flatpickr error in the console. To test apply the patch and go to Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file. - Click "Add orders" next to the staged file you want to use. - On the "Add orders" page, test that everything still works correctly: - Tabs work correctly - JavaScript controls (select all, show inactive, etc.) work - MARC and Card previews work - Adding orders works Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134659|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134680&action=edit Bug 30384: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As the bugs that depend on this aren't yet signed off I'm marking this as 22_11 candidate to delay it and shrink the queue for our RM a little at this late stage. It'll go in very early next cycle to prevent the need for rebases. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Patchset does not apply cleanly to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.