[Bug 31881] New: Link in MARC view does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Bug ID: 31881 Summary: Link in MARC view does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 142219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142219&action=edit Bug 31881: Fix search link in MARC view In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. With Zebra looks like the idx param is ignored. Test plan : 1) Use Elasticsearch search engine 2) Edit subfield 245$a in default framework 3) Enter 'title' in 'Link' 4) Save 5) Create a record with default framework with 245$a = 'The Fifth Elephant' 6) Go to MARC view 7) Click on link in 245$a 8) You find the record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142219|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142246&action=edit Bug 31881: Fix search link in MARC view In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. With Zebra looks like the idx param is ignored. Test plan : 1) Use Elasticsearch search engine 2) Edit subfield 245$a in default framework 3) Enter 'title' in 'Link' 4) Save 5) Create a record with default framework with 245$a = 'The Fifth Elephant' 6) Go to MARC view 7) Click on link in 245$a 8) You find the record Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not created here, but how ugly is this: [% IF ( subfiel.link ) %] subfiel ?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. Not sure about this one. Are we really resolving the problem or just creating a workaround? You say that the query contains 'field'. Isnt that just misconfiguration? The framework column link should contain a valid index? Please clarify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Marcel de Rooy from comment #4)
Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'.
Not sure about this one. Are we really resolving the problem or just creating a workaround?
You say that the query contains 'field'. Isnt that just misconfiguration? The framework column link should contain a valid index?
Please clarify.
Sure. In test plan, framework column link contains 'title' which is a valid 'index' (= search field). Actually the build search link contains the search field twice : &idx=title,phr &q=title,phr:... I think we want to build a search query like it as been created from advanced search. So keep '&idx' and remove search field from '&q'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142246|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 143174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143174&action=edit Bug 31881: Fix search link in MARC view In framework a subfield can be defined with a link (with a search field). This create an hyperlink in MARC view. Currently with Elasticsearch the link does not work because search query contains 'field,phr:', which is useless since the link contains 'idx=field,phr'. With Zebra looks like the idx param is ignored. Test plan : 1) Use Elasticsearch search engine 2) Edit subfield 245$a in default framework 3) Enter 'title' in 'Link' 4) Save 5) Create a record with default framework with 245$a = 'The Fifth Elephant' 6) Go to MARC view 7) Click on link in 245$a 8) You find the record Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #5)
I think we want to build a search query like it as been created from advanced search. So keep '&idx' and remove search field from '&q'.
Great. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.09 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.09 |22.11.00, 22.05.09, released in| |21.11.16 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31881 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org