[Bug 20004] New: Adapt /v1/cities to new naming guidelines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Bug ID: 20004 Summary: Adapt /v1/cities to new naming guidelines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Cities_endpoint_R | |FC Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 70627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70627&action=edit Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 70628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70628&action=edit Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19774 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686 [Bug 19686] Add to_model and to_api params to objects.search helper -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |claire_gravely@hotmail.com --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Patch does not apply Applying: Bug 20004: Adapt /v1/cities to new naming guidelines fatal: sha1 information is lacking or useless (api/v1/swagger/parameters.json). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70627|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 71649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71649&action=edit Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70628|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 71651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71651&action=edit Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71651|0 |1 is obsolete| | --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71653&action=edit Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71649|0 |1 is obsolete| | --- Comment #7 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71665&action=edit Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71653|0 |1 is obsolete| | --- Comment #8 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71666&action=edit Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71665|0 |1 is obsolete| | Attachment #71666|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71823&action=edit Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71823|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71824&action=edit Bug 20004: Unit tests This patch adapts the unit tests for the cities endpoint to the requirements from the RFC. This tests are expected to just fail without the needed followup. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests obviously don't pass without the followup patch. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71825&action=edit Bug 20004: Adapt /v1/cities to new naming guidelines This patch implements the changes required by the cities endpoint RFC [1]. It uses the objects.search helper, and relies on bug 19686. To test: - Apply the patches - Compare the spec with the RFC (api/v1/swagger/definitions/city.json) => SUCCESS: It makes sense - Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71826&action=edit Bug 20004: Fix POD Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #12)
Created attachment 71826 [details] [review] Bug 20004: Fix POD
Well, you are cheating QA tests here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org