https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #32 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Katrin Fischer from comment #31)

As the both text blocks appear to be added by this patch set - could we reuse the same text block for both, defined in one spot?

Hum.. Yes I tried to focus on the change needed. I think the page needs a cleanup out from this scope. The business of the function was quite messy, with multiple variables containing the same information but for different purposes (for example has_issues and has_checkout do not have the same content according to the fact the user can or cannot be discharged). In a first while, we should probably use two different texts, one referring to the fact that the user cannot ask for a discharge and one referring to the fact that user's state has changed between the load of the page and the click on the discharge button (but tbh I don't know if anyone will see it). In a second while, I'll submit a separate patch to de-duplicate variables and clean the function itself. I think this will be easier to track the changes so. Does this solution looks fine for you ? -- You are receiving this mail because: You are watching all bug changes.