[Bug 20163] New: Position of NoLoginInstructions text is inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Bug ID: 20163 Summary: Position of NoLoginInstructions text is inconsistent Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: margaret@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 71356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71356&action=edit Side By Side NoLoginInstructions Text Comparison The position of NoLoginInstructions text is inconsistent between the "log into your account" popup and the "log into your account" main login form. In this case directional language is used in the NoLoginInstructions to have patrons look "above" for the Register here link. However in the popup the position of the two texts are flipped, so that the Register here link appears bellow the NoLoginInstructions. See Screenshot, "Side By Side NoLoginInstructions Text Comparison" for this illustration. To replicate: 1) Enable PatronSelfRegistration system preference. 2) Enable the OpacResetPassword system preference. 3) Input directional language, ie. "look [above or bellow] for the Register here link, into the NoLoginInstructions syspref. 4) Open OPAC and look at the "log into your account" popup and the "log into your account" main login form. Your instructions to look above or bellow will be wrong in one one of these login windows. Can the order in which the editable (ie. NoLoginInstructions) and non-editable (ie. Register here and Forgot Password) text that appears in the "log into your account" main login form and popup be made consistent? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71357&action=edit Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71357|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71426&action=edit Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71426|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71532&action=edit Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Includes string changes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org