[Bug 30901] New: Add template method to be able to look up renewal data in Koha slips and notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Bug ID: 30901 Summary: Add template method to be able to look up renewal data in Koha slips and notices Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be useful to be able to report renewals used/remaining in some notices and slips. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135687&action=edit Bug 30901: Add Renewals method to CirculationRules template plugin It would be useful to be able to report renewals used/remaining in some notices and slips. Test Plan: 1) Apply this patch 2) Add the following to the RENEWAL notices: -- [% USE CirculationRules %] [% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %] You have used [% renewals.count %] of [% renewals.allowed %], you have [% renewals.remaining %] renewals left. -- 3) Trigger a renewal notice 4) Verify the text is correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135688&action=edit Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135688|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135689&action=edit Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135687|0 |1 is obsolete| | Attachment #135689|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135690&action=edit Bug 30901: Add Renewals method to CirculationRules template plugin It would be useful to be able to report renewals used/remaining in some notices and slips. Test Plan: 1) Apply this patch 2) Add the following to the RENEWAL notices: -- [% USE CirculationRules %] [% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %] You have used [% renewals.count %] of [% renewals.allowed %], you have [% renewals.remaining %] renewals left. -- 3) Trigger a renewal notice 4) Verify the text is correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 135691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135691&action=edit Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135690|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135692&action=edit Bug 30901: Add Renewals method to CirculationRules template plugin It would be useful to be able to report renewals used/remaining in some notices and slips. Test Plan: 1) Apply this patch 2) Add the following to the RENEWAL notices: -- [% USE CirculationRules %] [% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %] You have used [% renewals.count %] of [% renewals.allowed %], you have [% renewals.remaining %] renewals left. -- 3) Trigger a renewal notice 4) Verify the text is correct! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135691|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135693&action=edit Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you please add some documentation for this? I think the wiki page would be a good place: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #8)
Could you please add some documentation for this?
I think the wiki page would be a good place: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit
Done! https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit#Using_fil... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's handy but cannot we already provide the same output without this patch?
From the patron object you can get the number of renews, the CirculationRules will give you the values for the renewal rules, and then it's a subtraction.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)
It's handy but cannot we already provide the same output without this patch? From the patron object you can get the number of renews, the CirculationRules will give you the values for the renewal rules, and then it's a subtraction.
I think it sounds more complicated for users, tbh. Could you write up a working example to document? I think patron object is not correct or we need another step to the issue and then calculate a lot of things. At the moment the main issue using TT notices is that you practically need to read and understand the code for anything a little out of the ordinary :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #12 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Jonathan Druart from comment #10)
It's handy but cannot we already provide the same output without this patch? From the patron object you can get the number of renews, the CirculationRules will give you the values for the renewal rules, and then it's a subtraction.
I would love to know how to do this. Would it be possible to document it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31048 [Bug 31048] Add information about remaining renewals to sample RENEWAL notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we needs ways to make TT in the templates easier to use. This is handy, easy to read and well documented now. Only: unit tests please! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 136748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136748&action=edit Bug 30901: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks great, very useful. I QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135692|0 |1 is obsolete| | --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 139086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139086&action=edit Bug 30901: Add Renewals method to CirculationRules template plugin It would be useful to be able to report renewals used/remaining in some notices and slips. Test Plan: 1) Apply this patch 2) Add the following to the RENEWAL notices: -- [% USE CirculationRules %] [% SET renewals = CirculationRules.Renewals( borrower.id, item.id ) %] You have used [% renewals.count %] of [% renewals.allowed %], you have [% renewals.remaining %] renewals left. -- 3) Trigger a renewal notice 4) Verify the text is correct! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135693|0 |1 is obsolete| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 139087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139087&action=edit Bug 30901: Add POD for Koha::Template::Plugin::CirculationRules Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136748|0 |1 is obsolete| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 139088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139088&action=edit Bug 30901: Add Unit Tests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a way to print release notes| |information about renewals | |to notices with Template | |Toolkit. | |Documentation: | |https://wiki.koha-community | |.org/wiki/Notices_with_Temp | |late_Toolkit#Example:_Circu | |lationRules.Renewals Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds a way to print |This adds a way to print release notes|information about renewals |information about renewals |to notices with Template |to notices with Template |Toolkit. |Toolkit. This includes the |Documentation: |numbers for used renewals, |https://wiki.koha-community |allowed renewals and |.org/wiki/Notices_with_Temp |remaining renewals and |late_Toolkit#Example:_Circu |more. |lationRules.Renewals |Documentation: | |https://wiki.koha-community | |.org/wiki/Notices_with_Temp | |late_Toolkit#Example:_Circu | |lationRules.Renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://wiki.koha-community submission| |.org/wiki/Notices_with_Temp | |late_Toolkit#Example:_Circu | |lationRules.Renewals CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rajujogi.t@gmail.com --- Comment #21 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- *** Bug 33301 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org