[Bug 31518] New: Hidden items count not displayed on hold request page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Bug ID: 31518 Summary: Hidden items count not displayed on hold request page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Hold requests Assignee: joonas.kylmala@iki.fi Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If I go place a hold on staff interface (request.pl) and the staff member logged in has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings and a biblio has a lost item then we get on the page the following link:
Show all items ( hidden)
The lost/hidden item count is missing due to a syntax error, it should read:
Show all items (1 hidden)
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140198&action=edit Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count The variable set by request.pl doesn't have biblio prefix, it is just hiddencount. To test: 1) Log in with a staff member account that has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings 2) Add a lost item to biblio 3) Go place a hold on staff interface (request.pl) notice the broken link on the request page: "Show all items ( hidden)" 4) After applying the patch it should read "Show all items (1 hidden)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140198|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140268&action=edit Bug 31518: Fix syntax error on request.tt that prevents showing hidden item count The variable set by request.pl doesn't have biblio prefix, it is just hiddencount. To test: 1) Log in with a staff member account that has "Lost items in staff interface" setting set to "Hidden by default" in the patron category settings 2) Add a lost item to biblio 3) Go place a hold on staff interface (request.pl) notice the broken link on the request page: "Show all items ( hidden)" 4) After applying the patch it should read "Show all items (1 hidden)" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Great catch, thx Joonas! Moving to PQA directly as this is an obvious template variable fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31518 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org