[Bug 27289] New: Template tweaks for point of sale page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Bug ID: 27289 Summary: Template tweaks for point of sale page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 23354 I have a couple of minor updates for the point of sale page: - buttons inside tables should use "btn-xs" to be a consistent size - required fields in the "Collect payment" form should be styled as required Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] "Add" button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114557&action=edit Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114557|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114756&action=edit Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Seems we were working on similar things around the same time.. Thanks for the fixes here.. they look good.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Bug 27289 depends on bug 27256, which changed state. Bug 27256 Summary: "Add" button on point of sale page fails on table paging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have a small issue here: The "required" fields now trigger their warning as soon as you add an item to the tab and before "Confirm" is hit cluttering up the page some. Could we move the check to trigger once you try to confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 27289 should certainly come into play for the above I think... are you happy to continue here Owen? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 [Bug 27427] Update the way form validation errors are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27427 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27427 [Bug 27427] Update the way form validation errors are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #4)
I have a small issue here: The "required" fields now trigger their warning as soon as you add an item to the tab and before "Confirm" is hit cluttering up the page some. Could we move the check to trigger once you try to confirm?
This has always triggered.. I just double checked against master.. that changes here don't affect this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114756|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116387&action=edit Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116388&action=edit Bug 27289: (follow-up) Update payment type too. The payment type field is also required when using cash registers, this patch updates the formatting to work as expected in that case too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added a follow-up to also set the proper display for payment type, which is also a required field. As for the validation, it is dealt with in the blocked bug.. I now remove the call to valid as requested here.. but do it when handling other validation issues in that pre-existing bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27427 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just feel that: This field is required. Required is a little much to see it all the time :) The doubled up text has not been present before this patch and I think is what Owen was contemplating on bug 27427 that we should try to move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116387|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116469&action=edit Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced <input type="number"> according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116388|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116470&action=edit Bug 27289: (follow-up) Update payment type too. The payment type field is also required when using cash registers, this patch updates the formatting to work as expected in that case too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, looking at this on master again - payment type is required, but cannot be unset.. so do we need to mark it in red? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 In odrer to push Bug 27290 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05. Please rebase so I can push bug 27290 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Andrew Fuerste-Henry from comment #16)
Doesn't apply cleanly to 20.05. Please rebase so I can push bug 27290
Hmm, Not sure it's required to go back that far? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org