[Bug 25274] New: JavaScript error in OPAC cart when more details are shown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Bug ID: 25274 Summary: JavaScript error in OPAC cart when more details are shown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: barton@bywatersolutions.com, jonathan.druart@bugs.koha-community.org, josef.moravec@gmail.com, katrin.fischer@bsz-bw.de, marjorie.barry-vila@collecto.ca, martin.renvoize@ptfs-europe.com, nengard@gmail.com, nick@bywatersolutions.com, patrick.robitaille@collecto.ca Depends on: 7547 The fix for Bug 7547 caused a JavaScript error in the OPAC cart when the "More details" view is selected. The part of the script which adds the print button breaks when the DataTable isn't there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 [Bug 7547] Printing a sorted cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103668&action=edit Bug 25274: Don't initialize DataTable if table isn't present This patch modifies the OPAC basket JavaScript so that a check is added for the existence of the "itemst" table. This avoids an error if the "More details" view is selected and hte "itemst" table isn't present. To reproduce the error, add some items to the OPAC cart and open the cart window. Open the JavaScript console in your browser and click the "More details" link. You'll see an error. To test, apply the patch and perform the same test as above. The error should not be present. Test that table sorting in the "brief" view words correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 [Bug 25271] Add floating toolbar to OPAC cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103668|0 |1 is obsolete| | --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 103669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103669&action=edit Bug 25274: Don't initialize DataTable if table isn't present This patch modifies the OPAC basket JavaScript so that a check is added for the existence of the "itemst" table. This avoids an error if the "More details" view is selected and hte "itemst" table isn't present. To reproduce the error, add some items to the OPAC cart and open the cart window. Open the JavaScript console in your browser and click the "More details" link. You'll see an error. To test, apply the patch and perform the same test as above. The error should not be present. Test that table sorting in the "brief" view words correctly. Signed-off-by: David Roberts <david@koha-ptfs.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103669|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 103681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103681&action=edit Bug 25274: Don't initialize DataTable if table isn't present This patch modifies the OPAC basket JavaScript so that a check is added for the existence of the "itemst" table. This avoids an error if the "More details" view is selected and hte "itemst" table isn't present. To reproduce the error, add some items to the OPAC cart and open the cart window. Open the JavaScript console in your browser and click the "More details" link. You'll see an error. To test, apply the patch and perform the same test as above. The error should not be present. Test that table sorting in the "brief" view words correctly. Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25274 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org