https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Rogan Hamby <rogan.hamby@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rogan.hamby@gmail.com Assignee|gmcharlt@gmail.com |rogan.hamby@gmail.com Status|NEW |Needs Signoff --- Comment #1 from Rogan Hamby <rogan.hamby@gmail.com> --- Created attachment 94015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94015&action=edit Bug 18414 allow delete_patrons.pl to use a list of borrowernumbers Small patch to allow use of borrowernumbers in a text file for deletion. If used with filters specified they act as filters on the contents of the file. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Forget that last comment, it does not. You are testing for !defined $members and GetBorrowersToExpunge will always return an arrayref. I would prefer to see the code improved and more robust to avoid such regressions if we modify the return value. I cannot think of something right now, leaving for another QAer or will come back later to this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96574|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101116&action=edit Bug 18413: Allow to use other select criteria with delete_patrons.pl Adds the ability to specify a file with the --file flag that should be a list of borrowernumbers for deletion. If used without other flags it will delete the list of borrowers, if used with other flags it will treat the other criteria as filters for the list. To Test: 1) Specify a list, e.g. borrowers.txt, of borrowernumbers in the database and put them in a text file with one per line 2) Invoke the script like ./delete_patrons.pl --file borrowers.txt to delete those patrons 3) Populate the list with a mix of borrowers in a category and those not, say categoryfoo 4) Invoke the scirpt as ./delete_patrons.pl --category_code categoryfoo --file borrowers.txt 5) Only the borrowers in the file that have the specified category will be deleted Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=18414 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds the ability to specify release notes| |a file with the --file flag | |that | |should be a list of | |borrowernumbers for | |deletion. | |If used without | |other flags it will delete | |the list of borrowers, if | |used with other flags it | |will treat the other | |criteria as filters for the | |list. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18414 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Adds the ability to specify |Adds the ability to specify release notes|a file with the --file flag |a file with the --file flag |that |that |should be a list of |should be a list of |borrowernumbers for |borrowernumbers for |deletion. |deletion. |If used without | |other flags it will delete |If used without |the list of borrowers, if |other flags it will delete |used with other flags it |the list of borrowers, if |will treat the other |used with other flags it |criteria as filters for the |will treat the other |list. |criteria as filters for the | |list. -- You are receiving this mail because: You are watching all bug changes.