[Bug 26862] New: MARC 530 is missing a descriptive lavel in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Bug ID: 26862 Summary: MARC 530 is missing a descriptive lavel in the OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org In the XSLT 530 is missing a label with the description of the field. To test: - Catalog a 530 in any record - Verify the display in the OPAC and staff is missing the label and the content appears in a different size than the rest of the entries from the bibliographic record http://www.loc.gov/marc/bibliographic/bd530.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|MARC 530 is missing a |MARC 530 is missing a |descriptive lavel in the |descriptive label in the |OPAC |OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152989&action=edit Bug 26862: Improve MARC21 530 display on detail pages This makes some changes to the way we display field 530 in OPAC and staff interface: * Adds missing spaces before $u and between repeated $u subfields * Adds a description/label before the output of the subfields * Adds display to the staff interface (was OPAC only) * Adds separators between repeated 530 fields: * OPAC: updates mark-up to use the new CSS driven separators * Staff interface: adds | with separator class To test: * Find or create a records with multiple 530 entries * Repeat $u with multiple URLs * Verify display in staff (missing) and OPAC * Apply patch * Verify display is improved :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC 530 is missing a |MARC21 530 is missing from |descriptive label in the |staff interface and has no |OPAC |label -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152989|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152990&action=edit Bug 26862: Improve MARC21 530 display on detail pages This makes some changes to the way we display field 530 in OPAC and staff interface: * Adds missing spaces before $u and between repeated $u subfields * Adds a description/label before the output of the subfields * Adds display to the staff interface (was OPAC only) * Adds separators between repeated 530 fields: * OPAC: updates mark-up to use the new CSS driven separators * Staff interface: adds | with separator class To test: * Find or create a records with multiple 530 entries * Repeat $u with multiple URLs * Verify display in staff (missing) and OPAC * Apply patch * Verify display is improved :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152990|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 152993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152993&action=edit Bug 26862: Improve MARC21 530 display on detail pages This makes some changes to the way we display field 530 in OPAC and staff interface: * Adds missing spaces before $u and between repeated $u subfields * Adds a description/label before the output of the subfields * Adds display to the staff interface (was OPAC only) * Adds separators between repeated 530 fields: * OPAC: updates mark-up to use the new CSS driven separators * Staff interface: adds | with separator class To test: * Find or create a records with multiple 530 entries * Repeat $u with multiple URLs * Verify display in staff (missing) and OPAC * Apply patch * Verify display is improved :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the display of release notes| |the MARC21 530 tag and | |subfields so that it: | |- now | |displays in the staff | |interface (was missing) | |- | |improves the display of the | |values by adding | | . a | |description/label | | . | |separators between repeated | |530 tags | | . missing spaces | |before $u and between | |repeated $u subfields --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Change the BKS framework so that 530 can be edited in the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152993|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153077&action=edit Bug 26862: Improve MARC21 530 display on detail pages This makes some changes to the way we display field 530 in OPAC and staff interface: * Adds missing spaces before $u and between repeated $u subfields * Adds a description/label before the output of the subfields * Adds display to the staff interface (was OPAC only) * Adds separators between repeated 530 fields: * OPAC: updates mark-up to use the new CSS driven separators * Staff interface: adds | with separator class To test: * Find or create a records with multiple 530 entries * Repeat $u with multiple URLs * Verify display in staff (missing) and OPAC * Apply patch * Verify display is improved :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, David and Heather! Heather, if I work on other XSLT patches, would you like me to CC you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #7 from Heather <heather_hernandez@nps.gov> --- Sure, Katrin! Yes, please do! I felt that this was a bug I could really test.:) Happy to help! --h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- <xsl:attribute name="href"><xsl:value-of select="text()"/></xsl:attribute> You might need to str-encode-uri and normalize-space stuff here. Something like (do not copy): <xsl:value-of select="str:encode-uri(concat($scriptname,'?q=ti,phr:',translate($quoted_title, '()', '')),false())"/> <xsl:value-of select="normalize-space(marc:subfield[@code=$cnum_subfield])"/> Why do you open a new window in OPAC (pref dependent) and not in staff? Could imagine that staff could have it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8)
<xsl:attribute name="href"><xsl:value-of select="text()"/></xsl:attribute> You might need to str-encode-uri and normalize-space stuff here. Something like (do not copy): <xsl:value-of select="str:encode-uri(concat($scriptname,'?q=ti,phr:', translate($quoted_title, '()', '')),false())"/> <xsl:value-of select="normalize-space(marc:subfield[@code=$cnum_subfield])"/>
You might ignore this remark looking at e.g. 856u -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
You might ignore this remark looking at e.g. 856(In reply to Marcel de Rooy from comment #8) <xsl:attribute name="href"><xsl:value-of select="text()"/></xsl:attribute> You might need to str-encode-uri and normalize-space stuff here. Something like (do not copy): <xsl:value-of select="str:encode-uri(concat($scriptname,'?q=ti,phr:', translate($quoted_title, '()', '')),false())"/> <xsl:value-of select="normalize-space(marc:subfield[@code=$cnum_subfield])"/>
This part pre-dates my patch, I can have a look at 856.
Why do you open a new window in OPAC (pref dependent) and not in staff? Could imagine that staff could have it.
Because we don't have an equivalent of the pref for the staff interface and we don't use the OPAC one in staff either. I stumbled on that too when working on the patch, should maybe have left a note :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #10)
You might ignore this remark looking at e.g. 856(In reply to Marcel de Rooy from comment #8) <xsl:attribute name="href"><xsl:value-of select="text()"/></xsl:attribute> You might need to str-encode-uri and normalize-space stuff here. Something like (do not copy): <xsl:value-of select="str:encode-uri(concat($scriptname,'?q=ti,phr:', translate($quoted_title, '()', '')),false())"/> <xsl:value-of select="normalize-space(marc:subfield[@code=$cnum_subfield])"/>
This part pre-dates my patch, I can have a look at 856.
I had a look, but I am not sure this applies here. $u is a full URL here, not a parameter we use to build a search URL, so there should not be a need to encode it - it might even break things if it's already encoded. Do you agree?
Why do you open a new window in OPAC (pref dependent) and not in staff? Could imagine that staff could have it.
Because we don't have an equivalent of the pref for the staff interface and we don't use the OPAC one in staff either. I stumbled on that too when working on the patch, should maybe have left a note :)
See: Bug 29739 - Add a staff counterpart for OPACURLOpenInNewWindow Currently we only open the "OPAC" link and the links to authorities in a new tab, so behavior is consistent with this patch, even if it could be improved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153077|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153311&action=edit Bug 26862: Improve MARC21 530 display on detail pages This makes some changes to the way we display field 530 in OPAC and staff interface: * Adds missing spaces before $u and between repeated $u subfields * Adds a description/label before the output of the subfields * Adds display to the staff interface (was OPAC only) * Adds separators between repeated 530 fields: * OPAC: updates mark-up to use the new CSS driven separators * Staff interface: adds | with separator class To test: * Find or create a records with multiple 530 entries * Repeat $u with multiple URLs * Verify display in staff (missing) and OPAC * Apply patch * Verify display is improved :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passing QA. What I miss (not only here, but in general) is additional validation of what we entered in $u or similar fields. Learned by experience that there may be trailing spaces in such fields breaking URLs, and so on. And on the subject of new windows, I would rather open a new window by default than replace the current one just as we do now. But that may be a personal pref. We should indeed create the staff counterpart of the OPAC pref. So no blockers left here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26862 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org