[Bug 38952] New: JS function messenger not used in acq.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Bug ID: 38952 Summary: JS function messenger not used in acq.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/js/acq.js 166 function messenger(X,Y,etc){ // FIXME: unused? 167 win=window.open("","mess","height="+X+",width="+Y+",screenX=150,screenY=0"); 168 win.focus(); 169 win.document.close(); 170 win.document.write("<body link='#333333' bgcolor='#ffffff' text='#000000'><font size='2'><p><br />"); 171 win.document.write(etc); 172 win.document.write("<center><form><input type=button onclick='self.close()' value='Close'></form></center>"); 173 win.document.write("</font></body></html>"); 174 } % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/intranet-tmpl/prog/js/acq.js koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176942&action=edit Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176942|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177067&action=edit Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177067|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 177368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177368&action=edit Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | CC| |blawlor@clamsnet.org --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- QA notes: git log -G'messenger\(' This takes a long time but it finds the commit where calls to this function were removed. git log -p ca16532ea8270b14178ab47cb26f48c53f64a20a -G'messenger\(' This shows the diff of that commit Fix for Bug 5028 - Remove references to catmaintain.pl git grep -l 'messenger(' After patch returns no results Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177368|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177924&action=edit Bug 38952: Remove JS function messenger from acq.js Test plan: % git grep -l messenger koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf The function is unused and can be removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38952 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #8 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org