[Bug 31214] New: Regression: subfield code editable in MARC framework editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Bug ID: 31214 Summary: Regression: subfield code editable in MARC framework editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 5917 The Subfield code field is incorrectly editable in the MARC framework subfield configuration page, on e.g. on the page http://localhost:8081/cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=003&frameworkcode= This is an regression from bug 5917 – When converting the old templating syntax to Template toolkit syntax some of the code was missed and the old syntax was left in the codebase. In marc koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt the following line should be fixed:
[% IF ( subfieldcode == 0 || subfieldcode ) %]
it should be
[% IF ( loo.subfieldcode == 0 || loo.subfieldcode ) %]
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917 [Bug 5917] Switch Koha to use Template::Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Commit causing the regression: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We noticed this too and were torn between bug or feature, but it doesn't work right and isn't really useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 138743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138743&action=edit Bug 31214: Make subfield code non-editable in MARC framework editor The subfield code field became editable in framework editor due to a regression that happened during the switch from a previous template framework koha used to the new Template toolkit framework currently in use: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) The regression happened due to the template syntax not being updated to the new one in this particular case. Note: The subfield code field doesn't align with the other fields anymore after this patch. However, this alignment issue is in every other Koha form in intranet and should be fixed in the global CSS rules. 1) Apply patch 2) Browse to /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR 3) Notice the subfield code is non-editable 4) Notice the subfield code is still editable in the New tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138743|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138744&action=edit Bug 31214: Make subfield code non-editable in MARC framework editor The subfield code field became editable in framework editor due to a regression that happened during the switch from a previous template framework koha used to the new Template toolkit framework currently in use: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) The regression happened due to the template syntax not being updated to the new one in this particular case. Note: The subfield code field doesn't align with the other fields anymore after this patch. However, this alignment issue is in every other Koha form in intranet and should be fixed in the global CSS rules. 1) Apply patch 2) Browse to /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR 3) Notice the subfield code is non-editable 4) Notice the subfield code is still editable in the New tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138744|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138891&action=edit Bug 31214: Make subfield code non-editable in MARC framework editor The subfield code field became editable in framework editor due to a regression that happened during the switch from a previous template framework koha used to the new Template toolkit framework currently in use: Bug 5917 : Swapping templates over (5884fb100071e973daf671a4ada6b32724376768) The regression happened due to the template syntax not being updated to the new one in this particular case. Note: The subfield code field doesn't align with the other fields anymore after this patch. However, this alignment issue is in every other Koha form in intranet and should be fixed in the global CSS rules. 1) Apply patch 2) Browse to /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=995&frameworkcode=AR 3) Notice the subfield code is non-editable 4) Notice the subfield code is still editable in the New tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org