https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119898|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119902&action=edit Bug 12362: (QA follow-up) Fix ModItemTransfer cancellation handling ModItemTransfer is still used, sparingly. It force cancels transfers regardles of whether they are already marked as in_transit. We do not, however, want to enqueue a return transfer in this case as ModItemTransfer is itself an enqueue function. This patch updates the internal logic of ModItemTransfer to enqueue the passed transfer prior to cancelling the pre-existing one.. in this way the result is one cancelled transfer and one new transfer and not three transfers. Test plan 1/ Run t/db_dependant/Items.t and verify it fails prior to applying this patch 2/ Apply patch and run the test again, verifying it now passes. -- You are receiving this mail because: You are watching all bug changes.