[Bug 3614] New: Error in C4/Biblio.pm
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3614 Summary: Error in C4/Biblio.pm Product: Koha Version: unspecified Platform: PC OS/Version: Windows 2000 Status: NEW Severity: minor Priority: P3 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: kosmas@lib.uoc.gr Estimated Hours: 0.0 Change sponsored?: --- There is an error in C4/Biblio.pm lines 1712 and 1728 as of git commit 6970d3c1ae69e0bd4916a0162fd92722a7a967b2 The statement: $ind1 = " " if !defined($ind2) or $ind2 eq ""; should be changed to: $ind1 = " " if !defined($ind1) or $ind1 eq ""; -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
On 09/14/2009 12:35 PM, bugzilla-daemon@kohaorg.ec2.liblime.com wrote:
The statement:
$ind1 = " " if !defined($ind2) or $ind2 eq "";
should be changed to:
$ind1 = " " if !defined($ind1) or $ind1 eq "";
Well spotted. The typo is invited by the verbosity of the construct if ($ind1) { will check both definedness and that its not an empty string. worth mentioning because its a common idiom in the codebase Colin -- Colin Campbell Software Engineer, PTFS Europe Limited Content Management and Library Solutions +44 (0) 208 366 1295 (phone) +44 (0) 7759 633626 (mobile) colin.campbell@ptfs-europe.com skype: colin_campbell2 http://www.ptfs-europe.com
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3614 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs- | |europe.com Priority|P3 |PATCH-Sent --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2009-09-14 12:09:51 --- Posted a patch to fix this. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3614 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> 2009-09-14 17:43:55 --- Colin, your patch is not correct - consider what would happen if the indicator value is '0'. Giannis' suggested way of fixing this is on the right track. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3614 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> 2009-09-15 13:23:49 --- Patches fixing this pushed to HEAD. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3614 Giannis Kosmas <kosmas@lib.uoc.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3614 Giannis Kosmas <kosmas@lib.uoc.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (2)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com -
Colin Campbell