[Bug 22274] New: Self-checkout pages not covered by OPAC CSS changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Bug ID: 22274 Summary: Self-checkout pages not covered by OPAC CSS changes Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: oliver.behnke@aei.mpg.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Hi everyone, unfortunately the self-checkout module has been neglected/missed once again and the nice new 18.11 OPAC theme isn't yet applied to it, leading to an inconsistent UI. Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20554 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20554 CC| |katrin.fischer@bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 [Bug 20554] New OPAC CSS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #1 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- FYI, the same should also apply to the self-checkin module (/koha-tmpl/opac-tmpl/bootstrap/css/sci.css), I presume. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org Assignee|koha-bugs@lists.koha-commun |claire_gravely@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self-checkout pages not |Self-checkout/checkin pages |covered by OPAC CSS changes |not covered by OPAC CSS | |changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #2 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Created attachment 84809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84809&action=edit Crude patch for the SCO module This is a very crude patch for the SCO module. I took the relevant OPAC changes, converted the SCSS to CSS and applied them. Note: it's certainly not meant to be applied as is, as it might still be incomplete or even wrong in places. Yet it should hopefully kickstart and speed up things. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Hi, Thanks for the finding this and working on it. Do you seek tester on this patch? Or do you still need to work on it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #4 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi Victor, I just uploaded a *crude* patch that was simply meant as a workaround for others having the same problem. It's just a hack that I did to quickly fix our production site. I was hoping that those people responsible for the CSS changes in #20554 or those who developed the SCO/SCI layout would take of this problem and fix it "the right way". That said, I took that patch as far as I could but I wouldn't move that into testing before someone knowledgeable in the area signed off on it, or ideally, fixed/streamlined it first. For instance, I'm not using SCSS which bloats the code and shouldn't be committed that way. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Hi, sorry, it is on my to do list. I was on leave and have a busy couple of weeks coming up but will try and get it done ASAP! Thanks for pointing it out! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #6 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi Claire, I didn't mean to be pushy if I came across like that. Just wanted to clarify any potential misunderstandings :-) Glad to have you back! Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Thanks for the clarifications, the "new" status with a patch made me fear that there was a risk being forgotten during many months. But it turns out it's in good hands :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #8 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 87712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87712&action=edit Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #9 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks Claire! I'll check it out and get back to you ASAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self-checkout/checkin pages |Self-checkout pages not |not covered by OPAC CSS |covered by OPAC CSS changes |changes | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22638 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20554 |22638 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22638 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 [Bug 20554] New OPAC CSS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 [Bug 22638] Self checkin CSS update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84809|0 |1 is obsolete| | Attachment #87712|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87779&action=edit Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87780&action=edit Bug 22274: (follow-up) Use one CSS file for SCO and SCI This patch makes the self-checkin CSS created in Bug 22638 the CSS for self-checkout as well. The interfaces have the same requirements. This patch also replaces some old image-based icons with Font Awesome icons. To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Test both interfaces, confirming that the style is consistent for each and looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 14000 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #13 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Hi Owen, I tried to test the patches on our local test system and a number of hunks didn't apply. What's the baseline version for the patches? I'm on 18.11.04. Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #14 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- I don't think I can test this properly. The patches are partially rejected on my 18.11.04 test system and I didn't have much luck with various sandboxes either. Either they didn't even get back out of maintenance mode, or I couldn't deploy 22638 and 22274 simulateneously (docker-based SBs / required as they depend on each other) or the patches didn't seem to effective, despite testing 22638 by itself elsewhere did more or less work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87779|0 |1 is obsolete| | Attachment #87780|0 |1 is obsolete| | --- Comment #15 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88089&action=edit Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88089|0 |1 is obsolete| | --- Comment #16 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88090&action=edit Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #17 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88091&action=edit Bug 22274: (follow-up) Use one CSS file for SCO and SCI This patch makes the self-checkin CSS created in Bug 22638 the CSS for self-checkout as well. The interfaces have the same requirements. This patch also replaces some old image-based icons with Font Awesome icons. To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Test both interfaces, confirming that the style is consistent for each and looks correct. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88090|0 |1 is obsolete| | Attachment #88091|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88112&action=edit Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes This patch updates the Self-checkout pages to match the new OPAC style. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88113&action=edit Bug 22274: (follow-up) Use one CSS file for SCO and SCI This patch makes the self-checkin CSS created in Bug 22638 the CSS for self-checkout as well. The interfaces have the same requirements. This patch also replaces some old image-based icons with Font Awesome icons. To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable both self checkout (WebBasedSelfCheck) and self checkin (SelfCheckInModule). - Test both interfaces, confirming that the style is consistent for each and looks correct. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #20 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Thanks everyone for getting this done. Hopefully future OPAC CSS changes will include tests of the SCI/SCO modules as well :-) Cheers! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22772 [Bug 22772] Menu link hover color incorrect in OPAC language choosers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Bug 22274 depends on bug 22638, which changed state. Bug 22638 Summary: Self checkin CSS update https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22638 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org