[Bug 5180] New: Autocomplete broken on overdues report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Summary: Autocomplete broken on overdues report Change sponsored?: --- Product: Koha Version: HEAD Platform: All URL: /cgi-bin/koha/circ/overdue.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Circulation AssignedTo: gmcharlt@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Blocks: 5014 Estimated Hours: 0.0 There is a JavaScript error on the overdues report page. FireBug reports: YAHOO.widget.DS_XHR is not a constructor /cgi-bin/koha/circ/overdue.pl Line 126 This bug blocks Bug 5014 because without a working autocomplete I don't know if the markup corrections I think are required to fix 5014 will break the autocomplete. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8203&action=edit Bug 5180: FIX autocomplete on overdues report - Switch off the CircAutocompl syspref - Set a (one or more) patron attr type searchable - go on the overdues page Firebug crash and a layout problem appears on the left. Firebug error is "YAHOO.widget.DS_XHR is not a constructor" retry with this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is this still an issue? I can't seem to replicate it based on the description on the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathilde.formery@ville-nime | |s.fr -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #2)
Is this still an issue? I can't seem to replicate it based on the description on the patch.
I can't reproduce it either. Owen, still relevant ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8203|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8464&action=edit [SIGNED-OFF] Bug 5180: FIX autocomplete on overdues report - Switch off the CircAutocompl syspref - Set a (one or more) patron attr type searchable - go on the overdues page Firebug crash and a layout problem appears on the left. Firebug error is "YAHOO.widget.DS_XHR is not a constructor" retry with this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Yes, this is still an issue in master, and the test plan is the same as what I'm seeing. This patch disables the autocomplete when CircAutocompl is turned off, which may not be what everyone would expect. Perhaps CircAutocompl should be officially transformed into a global switch for autocomplete? jQueryUI will certainly make it easier to add more instances of it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_6 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : I can't reproduce the issue. However, it's a tiny patch, the code is correct and sound logical. There should be something specific in the configuration I can't reproduce. However, Jonathan and owen confirm the problem exist and the patch fixes it, I have no problem after applying the patch, so passed QA BREAKING NEWS: just 2sec before hitting "save", jonathan suggested something, now I can reproduce the problem = the attribute must be searchable and linked to an authorised value -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org