[Bug 37546] New: We should output error messages alongside error codes for z39.50 errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Bug ID: 37546 Summary: We should output error messages alongside error codes for z39.50 errors Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When performing a z39.50 search during cataloging, there are various errors that can be returned from ZOOM.. these have errors codes, but they also have nicer strings too.. which we're hiding! We should return both in the result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169953&action=edit Bug 37546: Output error message from ZOOM in Z3950 errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37547 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- How does one test this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Ohh I am curious about this as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- I found this whilst hitting a Z39.50 server that was misconfigured somewhere.. it's since working so I'm not able to offer a simple test plan.. The code is simple to read however.. we're just grabbing the message as well as the code now and displaying where we once only displayed the error code. It makes debugging Z connections easier basically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Could it be possible to enable the publicserver in the Koha Zebra config, and have Koha talk to it's own Z39.50 server? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Yes we can! Add a new Z39.50 server with these settings: Hostname: localhost Port: 2100 Database: biblios Syntax: MARC21/USMARC But not sure how to tweak the config to make it return relevant error codes? I tried changing <retrieval syntax="usmarc" name="marc21"/> to <retrieval syntax="usmarc" name="nope"/> in /etc/koha/sites/kohadev/z3950/config.xml, but that still gives results. There was something else I tried that just gave "No results". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- PS I tested this in KTD, and started it with "ktd --es7 up", since the "Z39.50 responder" relies on Elasticsearch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is such a trivial and clear bugfix in code. It really helps debug Z connections down the line if you come across any. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from David Cook <dcook@prosentient.com.au> --- I also tried messing with the Zebra config but with no luck, but I was able to trigger the code added by the patch, so yay! Basically, I uncomment "publicserver" in the koha-conf.xml, restart the Zebra server, make note of the TCP port used by zebrasrv (you could assign a port in koha-conf.xml but anyway...), setup the Koha Z39.50 server, but set it to UNIMARC instead of USMARC. Then when I do a Keyword search for "test", I get the following: KOHA record 1: 239 - Record syntax not supported KOHA record 2: 239 - Record syntax not supported - I am going to mark it as Failed QA for now, because I think this is misleading. Instead of "record", I think I'd say "result". I'm going to upload a screenshot of my test, and then add some more commentary... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 176422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176422&action=edit Example error message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Magnus Enger from comment #7)
PS
I tested this in KTD, and started it with "ktd --es7 up", since the "Z39.50 responder" relies on Elasticsearch.
Note that my test plan doesn't work with the z3950_responder.pl since it appears to ignore the syntax sent with the Z39.50 query... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #9)
I am going to mark it as Failed QA for now, because I think this is misleading.
Instead of "record", I think I'd say "result". I'm going to upload a screenshot of my test, and then add some more commentary...
I think it would be wise to wrap the Z39.50 error message in quotes. At first, I thought 239 might be the bib number, and then I thought there might be a bug... and then I realised that "239" is actually the error code. So it might also be worthwhile to write it out like... "[Error code: 239] - Record syntax not support" If you look at https://www.loc.gov/z3950/agency/contributions/1.html they suggest a "Recommended display" but it would require way too much work I reckon. But... we could do a hybrid like: "Record syntax not supported (ref. 239)" Because then I search "z39.50 ref 239" in a search engine, and I get useful data for my first hit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Sorry for all the messages... Additionally, it could be worthwhile wrapping the server data too: "[Server: KOHA]" Alternatively, I suppose to be more in line with other errors that say "failed to SERVER" or "timeout to SERVER": "Record syntax not supported (ref. 239) from KOHA" -- Anyway, now we have a reproducible test plan, this should be an easy one to move forward :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169953|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176423&action=edit Bug 37546: Output error message from ZOOM in Z3950 errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176424&action=edit Bug 37546: Error message output improvements As suggested by David, I've re-arranged the message output so we pass 'message' first, followed by the error reference inside brackets, followed by "for SERVER" and finally "result No." This follows the Z39.50 suggestions more closely whilst still including our level of detail for Server + Result number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Hows that ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #16)
Hows that ?
Good enough for me :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176423|0 |1 is obsolete| | --- Comment #18 from David Cook <dcook@prosentient.com.au> --- Created attachment 176482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176482&action=edit Bug 37546: Output error message from ZOOM in Z3950 errors Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176424|0 |1 is obsolete| | --- Comment #19 from David Cook <dcook@prosentient.com.au> --- Created attachment 176483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176483&action=edit Bug 37546: Error message output improvements As suggested by David, I've re-arranged the message output so we pass 'message' first, followed by the error reference inside brackets, followed by "for SERVER" and finally "result No." This follows the Z39.50 suggestions more closely whilst still including our level of detail for Server + Result number. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #16)
Hows that ?
Oh man... looking at it again today... your change was even smaller than I realised. Sorry for my earlier feedback. That misleading wording was already there. Blah. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Trivial patch with pretty big improvements. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176482|0 |1 is obsolete| | --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176515&action=edit Bug 37546: Output error message from ZOOM in Z3950 errors Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176483|0 |1 is obsolete| | --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176516&action=edit Bug 37546: Error message output improvements As suggested by David, I've re-arranged the message output so we pass 'message' first, followed by the error reference inside brackets, followed by "for SERVER" and finally "result No." This follows the Z39.50 suggestions more closely whilst still including our level of detail for Server + Result number. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|dcook@prosentient.com.au |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the output release notes| |displayed for errors | |returned from Z39.50 | |searches within Koha. Error | |messages and additional | |information are now shown | |for any error codes (when | |they are returned), making | |it easier to troubleshoot | |issues. | | | |The message output | |now has the 'message' | |first, followed by the | |error reference inside | |brackets, the "for | |[SERVERNAME]", and finally | |"result No." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #25 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- *** Bug 39273 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37546 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #27 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org