[Bug 27177] New: t/db_dependent/api/v1/holds.t failing after bug 26988
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Bug ID: 27177 Summary: t/db_dependent/api/v1/holds.t failing after bug 26988 Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 26988 After backporting bug 26988 to 20.05, we're failing t/db_dependent/api/v1/holds.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 [Bug 26988] Defer loading the hold pickup locations until the dropdown is selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 114277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114277&action=edit Bug 27177: Fix failing t/db_dependent/api/v1/holds.t To test: 1 - prove t/db_dependent/api/v1/holds.t 2 - it fails! 3 - apply patch, restart 4- prove t/db_dependent/api/v1/holds.t 5 - it passes! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114277|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114285&action=edit Bug 27177: Fix failing t/db_dependent/api/v1/holds.t To test: 1 - prove t/db_dependent/api/v1/holds.t 2 - it fails! 3 - apply patch, restart 4- prove t/db_dependent/api/v1/holds.t 5 - it passes! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) @QA: the script passes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Bug 27177 depends on bug 26988, which changed state. Bug 26988 Summary: Defer loading the hold pickup locations until the dropdown is selected https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26988 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think you are actually missing bug 27002. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I haven't been digging very deep, but this patch is wrong: 416 return try { 417 my @pickup_locations = 418 $hold->itemnumber 419 ? @{ $hold->item->pickup_locations( { patron => $hold->patron } )->as_list() } 420 : @{ $hold->biblio->pickup_locations( { patron => $hold->patron } )->as_list() }; vs 216 sub pickup_locations { ... 231 return \@pickup_locations; So you are calling ->as_list on an arrayref (I bet this is not tested in the tests are you trying to fix). As said in the previous comment, look at bug 27002 instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks, Jonathan. Closing this and pushing 27002 to 20.05 instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org