[Bug 29126] New: Accessibility: More corrections to contrast in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Bug ID: 29126 Summary: Accessibility: More corrections to contrast in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: accessibility Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: bolshawh@parliament.uk, martin.renvoize@ptfs-europe.com, testopia@bugs.koha-community.org Blocks: 28188 I've done some more checking for contrast problems in the OPAC and will submit a patch with various corrections. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125367&action=edit Bug 29126: Accessibility: More corrections to contrast in the OPAC This patch makes a few more corrections to OPAC CSS in order to avoid having elements which lack sufficient contrast, in particular parts of the interface where a standard-colored link appears on a darker background. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check the following pages/areas: - Breadcrumbs navigation - Datatables buttons (on the "Your summary" page) - Bibliographic view tabs (Normal/MARC/ISBD) on the bibliographic detail pages. - "Action" menu on the bibliographic detail pages: Place hold, print, etc. - Links inside "striped" tables: Links on the alternate grey background are darker to increase contrast. - Sidebar links on user pages: Your summary, your charges, etc. - Tag cloud: Approved tags in the weighted list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard@biblibre. | |com Status|Needs Signoff |Signed Off --- Comment #2 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Patch applied and changes checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125367|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 126053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126053&action=edit Bug 29126: Accessibility: More corrections to contrast in the OPAC This patch makes a few more corrections to OPAC CSS in order to avoid having elements which lack sufficient contrast, in particular parts of the interface where a standard-colored link appears on a darker background. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check the following pages/areas: - Breadcrumbs navigation - Datatables buttons (on the "Your summary" page) - Bibliographic view tabs (Normal/MARC/ISBD) on the bibliographic detail pages. - "Action" menu on the bibliographic detail pages: Place hold, print, etc. - Links inside "striped" tables: Links on the alternate grey background are darker to increase contrast. - Sidebar links on user pages: Your summary, your charges, etc. - Tag cloud: Approved tags in the weighted list. Signed-off-by: Jérémy Breuillard <jeremy.breuillard@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126053|0 |1 is obsolete| | --- Comment #4 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 126054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126054&action=edit Bug 29126: Accessibility: More corrections to contrast in the OPAC This patch makes a few more corrections to OPAC CSS in order to avoid having elements which lack sufficient contrast, in particular parts of the interface where a standard-colored link appears on a darker background. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check the following pages/areas: - Breadcrumbs navigation - Datatables buttons (on the "Your summary" page) - Bibliographic view tabs (Normal/MARC/ISBD) on the bibliographic detail pages. - "Action" menu on the bibliographic detail pages: Place hold, print, etc. - Links inside "striped" tables: Links on the alternate grey background are darker to increase contrast. - Sidebar links on user pages: Your summary, your charges, etc. - Tag cloud: Approved tags in the weighted list. Signed-off-by: Jérémy Breuillard <jeremy.breuillard@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126555&action=edit White on grey suspend links in holds list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, something is not quite right on My summary > holds in the OPAC, see screenshot. I ran the yarn build --view opac and restart_all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126661&action=edit Bug 29126: (follow-up) Correct color of btn-link class in striped tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The previous issue has went away, thx for the follow-up! I notice that we are now using 2 different "blues" for lighter and darker background. Example: http://localhost:8080/cgi-bin/koha/opac-readingrecord.pl * Links in the tabbed navigation on the left (#006394) * Table export options etc. on top of the table or "titles" in the table on dark background(#005580) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126054|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126808&action=edit Bug 29126: Accessibility: More corrections to contrast in the OPAC This patch makes a few more corrections to OPAC CSS in order to avoid having elements which lack sufficient contrast, in particular parts of the interface where a standard-colored link appears on a darker background. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check the following pages/areas: - Breadcrumbs navigation - Datatables buttons (on the "Your summary" page) - Bibliographic view tabs (Normal/MARC/ISBD) on the bibliographic detail pages. - "Action" menu on the bibliographic detail pages: Place hold, print, etc. - Links inside "striped" tables: Links on the alternate grey background are darker to increase contrast. - Sidebar links on user pages: Your summary, your charges, etc. - Tag cloud: Approved tags in the weighted list. Signed-off-by: Jérémy Breuillard <jeremy.breuillard@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126661|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126809&action=edit Bug 29126: (follow-up) Correct color of btn-link class in striped tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29126 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org