[Bug 26317] New: Misleading choices from reports error when runtime parameter is named incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26317 Bug ID: 26317 Summary: Misleading choices from reports error when runtime parameter is named incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: - create a new report from SQL - enter "SELECT <<whatever|whatever>>" and try to save - Get an error "Errors found when processing parameters for report: whatever: The authorized value category (whatever) you selected does not exist." - Error provides two options, "Save Anyway" or "Edit SQL" - Click Edit SQL, get taken to an empty report "Edit SQL" wants to take you back to the previously saved version of your report. But if you've ended up at this error from a brand new report that's never been saved, then the "Edit SQL" button is going to take you to a blank report, trashing whatever you've just written. If we can't retain that SQL through the error on an unsaved report, then we should remove the Edit SQL button when working with a report that hasn't been saved yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks ok for me on master (the SELECT is in the SQL textarea), did you test on master? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26317 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I just tested this on master a bit. There's some inconsistency in behavior here, perhaps based on complexity of the report? My original example of "SELECT <<whatever|whatever>>" does not drop any content when you try to save it. If I try to save a report of: SELECT if(1=1,'dur','ohno') WHERE poodle=<<dog|woof>> I click save, get the parameter error message, click "save anyway," end up with: SELECT if(1=1, Or, for a less silly example, this report has "branch" where it should say "branches": SELECT itemtypes.description as itemtype, branchname, sum(if(type='issue',1,0)) as issues, sum(if(type='renew',1,0)) as renews FROM statistics LEFT JOIN itemtypes USING (itemtype) LEFT JOIN branches ON (statistics.branch=branches.branchcode) WHERE date(datetime) BETWEEN <<Start date|date>> AND <<End date|date>> AND branch like <<Branch|branch:all>> GROUP BY itemtype, branch And after trying to save it I end up with: SELECT itemtypes.description as itemtype, branchname, sum(if(type= -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26317 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Altogether, I'd be happy see to see this check and error message moved to when a report is run, rather than when it's saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26317 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org