[Bug 14173] New: Paging on 'recent comments' page in OPAC is not displaying correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Bug ID: 14173 Summary: Paging on 'recent comments' page in OPAC is not displaying correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Created attachment 38992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38992&action=edit Screenshot of broken paging The recent comments paging is displayig the 'current' page to the right side of the paging list. (see screenshot) In order to test this you need to activate the page via system preference and then add 21+ comments to different records in your catalog. There is also a small bug, as we are missing a space before the 'by' in each entry. Verified on a somewhat recent master and a 3.18.5.1 installation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39756&action=edit Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like "insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00')" to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |bgkriegel@gmail.com CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 39759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39759&action=edit [Signed-off] Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like "insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00')" to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #39756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #3 from Marc Véron <veron@veron.ch> --- Setting to P3 since usability of OPAC is affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39759|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39799&action=edit Bug 14173: Paging on 'recent comments' page in OPAC is not displaying correctly This patch corrects the display of current page on a multipage recent comments. To test: 1) Enable OpacShowRecentComments 2) Add multiple comments to multiple records I used a script to add multiple lines like "insert into reviews values ($i, 51, $i, 'Comment $i', 1, '2015-06-01 00:00:00')" to table reviews 3) On OPAC, go to 'Recent comments', verify the bug 4) Apply the patch 5) Reload and check correct display Can't found missing space near 'by' from description. Display is correct for me. Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Tested on master, 3.20, 3.18, 3.16 and 3.14, the bug exist on all versions and the patch fixes it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Good catch Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Liz, can you pick this for 3.18 maybe? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Patch pushed to 3.18.x will be in 3.18.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org