[Bug 7092] New: Complete-subfield searches TraceCompleteSubfields syspref not working correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Bug #: 7092 Summary: Complete-subfield searches TraceCompleteSubfields syspref not working correctly Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: thatcher.rea@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org If TraceCompleteSubfields in 3.6 is set to force, clicking on the subject search links for a given bib generates a URL that looks similar to the following: opac-search.pl?q=(su,complete-subfield:{Cryptography})%20and%20(su,complete-subfield:{Juvenile%20literature.}) This will return no results when performing a subfield search for a given bib. I set TraceCompleteSubfields to "Don't force" and was able to search subjects again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #1 from Joy Nelson <joy@bywatersolutions.com> 2012-02-27 14:05:06 UTC --- Note: This system preference seems to fail on specific subject headings. It works on the 650 subject heading, but not the 651 subject heading. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Blocks| |7537 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- <magnuse> jcamins: got any hunches about bug 7092? like where to start digging? <jcamins> magnuse: yes. Try changing the {} quotes to "". <jcamins> magnuse: alternatively, use complete-field instead of complete-subfield. <magnuse> ok, that gives me somewhere to start - thank you very much! <magnuse> jcamins: chaning {} to "" seems to solve it! <jcamins> magnuse: yeah, Search.pm doesn't play well with ICU. <magnuse> jcamins: so a patch to replace {} with "" in the XSLT would solve bug 7092? or is it more of a quick and dirty workaround? <jcamins> magnuse: alas, it will *cause* bug 7092 on the installations that are still working. <magnuse> jcamins: ?? <magnuse> sounds like catch 22 or something, then... <jcamins> magnuse: C4::Search can't handle regular quotes with ICU enabled. <jcamins> magnuse: without ICU, C4::Search apparently can't handle {} <magnuse> ah, so what should be used depends on whether icu is used or not? <jcamins> That's what I've concluded. <magnuse> nice <jcamins> And, of course, you can't tell whether ICU is enabled. <magnuse> what to do then? add a syspref to choose {} or ""? <jcamins> magnuse: that's the best idea I can come up with. <magnuse> hm, i might try and add the syspref, then <magnuse> probably better to call it e.g. TraceCompleteSubfieldsQuoting than UseICU, right? cause it wouldn't actually influence the indexing... <jcamins> Better TracingQuotes or something like that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |magnus@enger.priv.no -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Looks like UNIMARC does not implement TraceSubjectSubdivisions and TraceCompleteSubfields, so I'll just do MARC21. Please correct me if I'm missing something! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 8010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8010&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref TracingQuotes for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC detail view: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su,complete-subfield:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, bot with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8010|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8069&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref TracingQuotes for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC detail view: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su,complete-subfield:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, bot with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8069|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 8118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8118&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref TracingQuotes for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC *and* intranet detail views: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su,complete-subfield:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, bot with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Magnus Enger <magnus@enger.priv.no> --- I forgot to implement TracingQuotes for the intranet. This new patch replaces the old one, and implements it for both the OPAC and the intranet. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8118|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8139&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref TracingQuotes for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC *and* intranet detail views: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su,complete-subfield:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, bot with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8139|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8140&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref TracingQuotes for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC *and* intranet detail views: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su,complete-subfield:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, bot with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Despite the length test plan, the change here is really pretty simple. It just adds a new system preference on how to quote tracings, and then implements that wrapper in the MARC21 Details XSLT using variables. Change to C4/XSLT.pm is just to make the module aware of the new preference. Marking as Passed QA. Still need followups for the other MARC flavours. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : if i'm not mistaking, the syspref is dependant on ICU use : if you've ICU, you *must* set it to {}, if you haven't it *must* be set to "" So I think this syspref should be called "ICU set yes/no", and it could be usefull for another use, and the TracingQuote is a wrong name -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8140|0 |1 is obsolete| | --- Comment #12 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 8225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8225&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref TracingQuotes for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle TracingQuotes, TraceCompleteSubfields and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC detail view: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include TracingQuotes = quotes opac-search.pl?q=su,complete-subfield:"Internet" TracingQuotes = curlybrace opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include TracingQuotes = quotes opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") TracingQuotes = curlybrace opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, bot with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) UPDATE 2012-03-16: Changed the name of the syspref from TracingQuotes to UseICU after a suggestion from Paul P., to make it more generally useful. I have used "Using/Not using" instead of "Use/Don't use" in the description of the syspref, to reflect the fact that this syspref will not change how Zebra does its indexing - it's just a way of telling Koha how the indexing is actually done. I have also set UseICU = 1 in updatedatabase.pl, since that will preserve the current behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new installations will not have ICU activated. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Magnus Enger <magnus@enger.priv.no> --- New patch attached, changing the name of the syspref from TracingQuotes to UseICU. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8225|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8227&action=edit Bug 7092 - Complete-subfield searches TraceCompleteSubfields syspref not working correctly This patch adds a syspref UseICU for toggling between using "" and {} for quoting in subject tracings. With normal Zebra indexing, "" must be used. With ICU Zebra indexing, {} must be used. This syspref interacts with TraceCompleteSubfields and TraceSubjectSubdivisions. To test: - marcflavour = MARC21 - make sure you have a record with a "complex subject", like "Internet -- Law and legislation" Toggle UseICU, TraceCompleteSubfields, and TraceSubjectSubdivisions and check that you get the expected results for the clickable links in the OPAC detail view: TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Don't include UseICU = Not using opac-search.pl?q=su:"Internet" UseICU = Using opac-search.pl?q=su:{Internet} TraceCompleteSubfields = Force TraceSubjectSubdivisions = Don't include UseICU = Not using opac-search.pl?q=su,complete-subfield:"Internet" UseICU = Using opac-search.pl?q=su,complete-subfield:{Internet} TraceCompleteSubfields = Don't force TraceSubjectSubdivisions = Include UsingICU = Not using opac-search.pl?q=(su:"Internet") and (su:"Law and legislation.") UsingICU = Using opac-search.pl?q=(su:{Internet}) and (su:{Law and legislation.}) TraceCompleteSubfields = Force TraceSubjectSubdivisions = Include UseICU = Not using opac-search.pl?q=(su,complete-subfield:"Internet") and (su,complete-subfield:"Law and legislation.") UseICU = Using opac-search.pl?q=(su,complete-subfield:{Internet}) and (su,complete-subfield:{Law and legislation.}) Check that clicking on the generated links gives the expected search results, but with normal and ICU indexing. (I have actually not tested this with ICU, so doing that before signing off is crucial.) UPDATE 2012-03-16: Changed the name of the syspref from TracingQuotes to UseICU after a suggestion from Paul P., to make it more generally useful. I have used "Using/Not using" instead of "Use/Don't use" in the description of the syspref, to reflect the fact that this syspref will not change how Zebra does its indexing - it's just a way of telling Koha how the indexing is actually done. I have also set UseICU = 1 in updatedatabase.pl, since that will preserve the current behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new installations will not have ICU activated. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I think this should probably go straight to Passed QA, as there has been no material change in the functionality code compared to the last iteration, which had passed QA. If anyone disagrees, you can change this back to "Signed off." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #12)
I have also set UseICU = 1 in updatedatabase.pl, since that will preserve the current behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new installations will not have ICU activated.
mmm... If I understand correctly, it means that someone not using ICU don't has a problem before your patch, and will have after, because the default value is 1 ? In this case, it's a bad idea : we should have libraries that have a working behaviour still working, and those with a buggy behaviour before the patch be warned that, if they change the new syspref, it will fix the behaviour Please confirm i'm wrong or change the default value ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Paul, (In reply to comment #16)
(In reply to comment #12)
I have also set UseICU = 1 in updatedatabase.pl, since that will preserve the current behaviour of Koha, but UseICU = 0 in sysprefs.sql, since most new installations will not have ICU activated.
mmm... If I understand correctly, it means that someone not using ICU don't has a problem before your patch, and will have after, because the default value is 1 ? In this case, it's a bad idea : we should have libraries that have a working behaviour still working, and those with a buggy behaviour before the patch be warned that, if they change the new syspref, it will fix the behaviour
Please confirm i'm wrong or change the default value ;-)
Not exactly. All existing Koha installations have tracings working as if UseICU is set to 1. While this may be causing problems that would be solved by changing UseICU to 0, setting UseICU to 1 will not break any existing installations that are working, while setting UseICU to 0 might. So the problem you described with the update breaking working installations is exactly why updatedatabase needs to set UseICU to 1. ;) Jared -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 --- Comment #18 from Magnus Enger <magnus@enger.priv.no> --- Thanks Jared, that was exactly what I was going to say. :-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- thanks for the confirmation i was wrong ;-) patch pushed (I haven't tested it, just checked that the updatedatabase is OK, te sysprefs.sql file can be loaded and the syspref can be set) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7092 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org