http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22912&action=edit Bug 11244 - notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch looks up each field in the information schema table, and if it is a date, datetime, or timestamp, it converts is to the format specified in the preference dateformat. Though the query in this patch looks like a mysql'ism, I believe it should also work in postgres at the very least. I believe we will in the near future move to Template Toolkit based notices which will render this issue moot. With TT notices, we will be able to use the KohaDates plugin to format dates correctly at that point. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22912|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22963&action=edit [SIGNED-OFF] Bug 11244 - notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This results in correctly-formatted dates, but I think we need to think about adding time to the output since we have hourly checkouts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23213&action=edit [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)

Kyle, what is your opinion on my patch? Maybe it is stupid, what do you think about it?

I think it's a far better solution than mine! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23711&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. http://bugs.koha-community.org/show_bug.cgi?id=10774 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like this idea, but I think we want to display the time in some cases - like for the due date in case of a hourly loan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23711|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23965&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23965|0 |1 is obsolete| | --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Created attachment 24557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24557&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. Signed-off-by: David Cook <dcook@prosentient.com.au> I love this patch! It is the best solution to this problem that I've seen. I think it is set up to perfectly handle dates in the notices. Unfortunately, the $dateonly flag is backwards, so the time is stripped from timestamps and 00:00:00 is added to dates without times. I'm adding a follow-up to reverse the setting of this flag. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti@jns.fi --- Comment #16 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Hi there! Applied the bug. I am noticing a huge performance drop with cronjobs/overdue_notices.pl getting 12 items to the message_queue takes 31s with this feature applied. getting 12 items to the message_queue takes 1s without this feature applied. oops... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Olli-Antti Kivilahti from comment #16)

Hi there!

Applied the bug. I am noticing a huge performance drop with cronjobs/overdue_notices.pl

getting 12 items to the message_queue takes 31s with this feature applied. getting 12 items to the message_queue takes 1s without this feature applied.

oops...

I've reproduced this problem as well, although I'm getting 35 items at around 31s. When I use strace, I'm noticing that 99% of the time is being spent on "brk" syscalls. I'm guessing the regex or the DateTime conversions are slowing things? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #18)

I thought about using DBIx::Class via Koha::Database to figure out the data type for the column, but I don't think that's going to be practical in this case, since the sourcename for the Koha::Schema::Result classes are sometimes quite different from the actual table name (e.g. borrowers vs Borrower, or MatcherMatchpoint vs matcher_matchpoints).

I suppose we also have to consider...is decreased performance worth having correct timestamps?

It might be worth testing this with a much larger load than 10-30 notices.

Sorry to keep spamming everyone, but perhaps it would be a good idea to add a "source_name" alias to each Result class so that we can use the actual table name as a source name when trying to use DBIx::Class. http://search.cpan.org/~ribasushi/DBIx-Class-0.08270/lib/DBIx/Class/ResultSo... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #16)

Hi there!

Applied the bug. I am noticing a huge performance drop with cronjobs/overdue_notices.pl

getting 12 items to the message_queue takes 31s with this feature applied. getting 12 items to the message_queue takes 1s without this feature applied.

oops...

I don't reproduce. I generated 10 overdues, and I got: koha@koha-qa:~/src (BZ11244↑⚡)% time perl misc/cronjobs/overdue_notices.pl perl misc/cronjobs/overdue_notices.pl 1.46s user 0.05s system 76% cpu 1.976 total koha@koha-qa:~/src (BZ11244↑⚡)% git checkout master Switched to branch 'master' koha@koha-qa:~/src (master⚡)% time perl misc/cronjobs/overdue_notices.pl perl misc/cronjobs/overdue_notices.pl 1.32s user 0.05s system 73% cpu 1.853 total I have 5 dates in the template: [skip] <<items.datelastborrowed>><<items.datelastseen>><<items.timestamp>> [skip] <<borrowers.dateofbirth>><<borrowers.dateexpiry>> [skip] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24558|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29651&action=edit [SIGNED-OFF] Bug 11244: (follow-up) Fix $dateonly flag At the moment, $dateonly is set to true when $1 is defined. However, since the regex capture group only includes the time, this flag will only be set when there is a value that includes a time. In effect, this means that timestamps are reduced to dates only, while dates have 00-00-0000 added to them. This patch keeps the logic but reverses the values, so that $dateonly will default to true unless $1 is defined. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29650|0 |1 is obsolete| | Attachment #29651|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30126&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. Signed-off-by: David Cook <dcook@prosentient.com.au> I love this patch! It is the best solution to this problem that I've seen. I think it is set up to perfectly handle dates in the notices. Unfortunately, the $dateonly flag is backwards, so the time is stripped from timestamps and 00:00:00 is added to dates without times. I'm adding a follow-up to reverse the setting of this flag. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle passed QA on the first patch, I pass QA on the second one. So the bug report is passed QA :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> --- Also i'd love to see some benchmarks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure about the implementation or its effects on performance of the job, but I'd really like to see this fixed. Notices are sent out to the patrons and nicely formatted dates would be great. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Chris Cormack from comment #30)

Also i'd love to see some benchmarks.

see comment 21. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and David! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13226 -- You are receiving this mail because: You are watching all bug changes.