https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120977|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120978&action=edit Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120978|0 |1 is obsolete| | --- Comment #3 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- Created attachment 122345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122345&action=edit Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam <hakam@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Hakam Almotlak from comment #4)

Created attachment 122346 [details] [review] Bug 28356: Consolidate catalogue search box code

To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers

Signed-off-by: hakam <hakam@inlibro.com>

You forgot to change status to "Signed off" no ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122346|0 |1 is obsolete| | --- Comment #7 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124814&action=edit Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam <hakam@inlibro.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Nice one! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 [Bug 26247] Search terms retained in header search creates UX inconsistency -- You are receiving this mail because: You are watching all bug changes.