[Bug 32611] New: Not for loan items don't show the specific not for loan value in OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Bug ID: 32611 Summary: Not for loan items don't show the specific not for loan value in OPAC detail page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When viewing a detailed record on the OPAC, we used to see the specific value of Not for loan (e.g. Ordered). Right now, any Not for loan value displays as "Not for loan" no matter what the authorized value description (or description (OPAC)) is. To test: 1. In the staff interface, edit an item 2. Change the Not for loan value to Ordered 3. Save 4. Click on "Normal" to see the detailed record --> Status is "Not for loan (Ordered)" 5. Click on "OPAC view: Open in new window." --> Status is "Not for loan". It should be "Ordered" 6. Try with any not for loan value --> Status stays "Not for loan". It should be whatever value you chose 7. Try changing the descriptions or descriptions (OPAC) in Administration > Authorized values > NOT_LOAN --> Status stays "Not for loan". It should be whatever you put in description (OPAC) or description, if description (OPAC) is empty I tested in 22.05(.07) and it shows Ordered (or whatever value I put). In master, it always shows "Not for loan". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could this be Bug 32445 - Status display of 'not for loan' items is broken in OPAC/staff ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #1)
Could this be Bug 32445 - Status display of 'not for loan' items is broken in OPAC/staff ?
That is what I thought too, but I didn't want to presume since the display was already broken before that patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147260&action=edit Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page This patch corrects what appear to be some copy-paste errors which resulted in the "not for loan" authorized value description not displaying, instead the generic "Not for loan" is shown. The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value. To test it's probably easiest to find a record with multiple items and set various item statuses (damaged, notforloan, lost, restricted) and confirm that the right description is shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147260|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147268&action=edit Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page This patch corrects what appear to be some copy-paste errors which resulted in the "not for loan" authorized value description not displaying, instead the generic "Not for loan" is shown. The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value. To test it's probably easiest to find a record with multiple items and set various item statuses (damaged, notforloan, lost, restricted) and confirm that the right description is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147268|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147400&action=edit Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page This patch corrects what appear to be some copy-paste errors which resulted in the "not for loan" authorized value description not displaying, instead the generic "Not for loan" is shown. The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value. To test it's probably easiest to find a record with multiple items and set various item statuses (damaged, notforloan, lost, restricted) and confirm that the right description is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Think this has introduced a different regression... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33933 [Bug 33933] Use restrictions appear twice for items on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32611 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32445 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org