[Bug 30580] New: GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Bug ID: 30580 Summary: GetItemsAvailableToFillHoldRequestsForBib should get transfers during initial query Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently we get the items, then loop over them checking for transfers - we can simply join to branch transfers in the initial query -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133560&action=edit Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133560|0 |1 is obsolete| | --- Comment #2 from Michal Urban <michalurban177@gmail.com> --- Created attachment 136797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136797&action=edit Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query Test result: Works as intended To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue Signed-off-by: Michal Urban <michalurban177@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michalurban177@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf method GetItemsAvailableToFillHoldRequestsForBib does not have a unit test yet. Please create one. It will ensure this change is harmless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Setting to Failed QA to make this show on Nick's radar :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139129&action=edit Bug 30580: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136797|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139130&action=edit Bug 30580: Don't use GetTransfers in GetItemsAvailableToFillHoldRequestsForBib This patch simply moves the check for transfers into the initial query To test: 1 - Place some holds that show in the holds queue 2 - Add a manual transfer to one item 3 - Confirm it no longer hsows in the queue 4 - Apply patch 5 - Confirm item still does not appear in the queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED CC| |joonas.kylmala@iki.fi --- Comment #7 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- This appears to be duplicate of bug 24295. Nick, could you attach the unit test you made here to bug 24295 as it doesn't have it? A QA round would be nice as well, so we could get the patches pushed on the same go :) *** This bug has been marked as a duplicate of bug 24295 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33761 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org