[Bug 29070] New: Accessibility: OPAC Purchase Suggestions on search results page has insufficient contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Bug ID: 29070 Summary: Accessibility: OPAC Purchase Suggestions on search results page has insufficient contrast Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bolshawh@parliament.uk QA Contact: testopia@bugs.koha-community.org The "Not finding what you're looking for? Make a purchase suggestion" text box on the search results page (opac-search.pl) is hard to read and fails to meet accessibility guidelines. WCAG 2.1 1.4.3 Contrast (Minimum) Level AA: "The visual presentation of text and images of text has a contrast ratio of at least 4.5:1, except for the following: - Large Text: Large-scale text and images of large-scale text have a contrast ratio of at least 3:1; - Incidental: Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement. - Logotypes: Text that is part of a logo or brand name has no contrast requirement." (https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#contrast-minimum) There are several free websites for checking the contrast ratio, e.g. https://webaim.org/resources/contrastchecker/ You can also use the built-in accessibility functions in Firefox and Chrome, as well as specialist accessibility browser extensions like WAVE (https://wave.webaim.org/) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility Blocks| |28188 Assignee|oleonard@myacpl.org |bolshawh@parliament.uk Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 --- Comment #1 from Henry Bolshaw <bolshawh@parliament.uk> --- Created attachment 125127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125127&action=edit Bug 29070: Accessibility OPAC Purchase suggestions box on search results page has insufficient contrast This patch changes the text colour for the purchase suggestion box on the OPAC search results page to make the text easier to read and improve accessibility. To test: 1. Log in to the OPAC and search for something 2. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio 3. Confirm that the Purchase suggestion text fails to meet accessibility requirements 4. Apply the patch and rebuild CSS: yarn build --view opac 5. Confirm the text contrast ratio now meets minimum accessibility requirements 6. Check that the OPAC still looks ok after the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125127|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125136&action=edit Bug 29070: Accessibility OPAC Purchase suggestions box on search results page has insufficient contrast This patch changes the text colour for the purchase suggestion box on the OPAC search results page to make the text easier to read and improve accessibility. To test: 1. Log in to the OPAC and search for something 2. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio 3. Confirm that the Purchase suggestion text fails to meet accessibility requirements 4. Apply the patch and rebuild CSS: yarn build --view opac 5. Confirm the text contrast ratio now meets minimum accessibility requirements 6. Check that the OPAC still looks ok after the changes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125136|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125325&action=edit Bug 29070: Accessibility OPAC Purchase suggestions box on search results page has insufficient contrast This patch changes the text colour for the purchase suggestion box on the OPAC search results page to make the text easier to read and improve accessibility. To test: 1. Log in to the OPAC and search for something 2. Use an accessibility tool (e.g. Chrome's Lighthouse tool) to check the contrast ratio 3. Confirm that the Purchase suggestion text fails to meet accessibility requirements 4. Apply the patch and rebuild CSS: yarn build --view opac 5. Confirm the text contrast ratio now meets minimum accessibility requirements 6. Check that the OPAC still looks ok after the changes. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125402&action=edit Bug 29070: Use a variable to store the #666666 color To prevent repetition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi Henry, As we are reusing the same HTML color code (#666666) it seems better to create a variable to reuse, instead of copying the same code everywhere. Better for maintainability if we need to modify it later on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29070 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org