[Bug 11773] New: Crash 'undefined value as a HASH' in sco-main.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Bug ID: 11773 Summary: Crash 'undefined value as a HASH' in sco-main.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 25304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25304&action=edit Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home › Administration › Currencies & Exchange rates › Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash wit error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25304|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25311&action=edit Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home › Administration › Currencies & Exchange rates › Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash wit error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25311|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25344&action=edit Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl Bug 11773 - Crash 'undefined value as a HASH' in sco-main.pl If no currency is defined as active and a patron with debts tries to check out in welf checkout moduel, sco-main.pl crashes with: Software error: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/opac/sco/sco-main.pl line 190. This patch tests for active currency and simply does not display a currency symbol if appropriate. Test plan: 1) Make sure you have a patron with debts and no currency defined as active. (Home › Administration › Currencies & Exchange rates › Currencies ) 2) Go to Self checkout module and try to checkout an item to this patron Result: Crash wit error message "Can't use an undefined value as a HASH..." 3) Apply patch 4) Reload and try to checkout again Expected result: Message "You owe the library..." without currency symbol 5) Define a currency as active and try to checkout again Expected result: Message "You owe..." with currency symbol Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marc! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11773 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org