[Bug 25614] New: "Clear filter" button permanently disabled on ILL request list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Bug ID: 25614 Summary: "Clear filter" button permanently disabled on ILL request list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com On the datatables filtering on the ILL requests page, the "Clear filter" button at the top of the table is permanently disabled, even when the filter text box is populated. It should only be disabled when the text box is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid. Owen, I've stared and glared... but can't figure it out. Would you mind having a look? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112565&action=edit Bug 25614: Move ILL request keyword filter to sidebar On the ILL request list page there are two filters for the table: One in the sidebar and one configured automatically by the DataTables plugin. I think these two systems are conflicting somehow to prevent the "clear filter" button in the table toolbar from working correctly. This patch doesn't fix the bug but avoids it: Since the filter field in the table toolbar is duplicating the functionality of the form in the sidebar, we could hide it and rely on the sidebar filter instead. To test, apply the patch and go to the ILL requests page in the staff interface. - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112565|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 115738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115738&action=edit Bug 25614: Move ILL request keyword filter to sidebar On the ILL request list page there are two filters for the table: One in the sidebar and one configured automatically by the DataTables plugin. I think these two systems are conflicting somehow to prevent the "clear filter" button in the table toolbar from working correctly. This patch doesn't fix the bug but avoids it: Since the filter field in the table toolbar is duplicating the functionality of the form in the sidebar, we could hide it and rely on the sidebar filter instead. To test, apply the patch and go to the ILL requests page in the staff interface. - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115738|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115816&action=edit Bug 25614: Move ILL request keyword filter to sidebar On the ILL request list page there are two filters for the table: One in the sidebar and one configured automatically by the DataTables plugin. I think these two systems are conflicting somehow to prevent the "clear filter" button in the table toolbar from working correctly. This patch doesn't fix the bug but avoids it: Since the filter field in the table toolbar is duplicating the functionality of the form in the sidebar, we could hide it and rely on the sidebar filter instead. To test, apply the patch and go to the ILL requests page in the staff interface. - The table of requests should display without a search form or "clear filter" button at the top. - The left-hand sidebar form should now have a "keyword" filter option which searches any column in the table. - Other filter fields should work as before. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for fixing this Owen. Works as expected, no QA failures. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28444 [Bug 28444] Filter/search box missing above main ILL table on 20.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org