https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127035&action=edit Bug 29334: Do not apply defaultvalue to existing auth record Note: The check in build_authorized_values_list with defaultvalue can be simplified since $value may already contain the defaultvalue. It is filled before the sub is called. The test for inserting a blank option is generalized; and may be still improved when using required attributes in the template? Note that we might experience some browser issues for these placeholders. Removed a few useless lines with respect to fields controlled by itemtypes. The last assignment to $value was useless and its probable intention unwanted (just use defaultvalue). Test plan: Put a defaultvalue in an authority framework. Add a new authority. Check for that value. Open existing authority. Clear field, save and reopen. Check if field is still empty. Bonus: test field controlled by authorised values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127035|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 127044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127044&action=edit Bug 29334: Do not apply defaultvalue to existing auth record Note: The check in build_authorized_values_list with defaultvalue can be simplified since $value may already contain the defaultvalue. It is filled before the sub is called. The test for inserting a blank option is generalized; and may be still improved when using required attributes in the template? Note that we might experience some browser issues for these placeholders. Removed a few useless lines with respect to fields controlled by itemtypes. The last assignment to $value was useless and its probable intention unwanted (just use defaultvalue). Test plan: Put a defaultvalue in an authority framework. Add a new authority. Check for that value. Open existing authority. Clear field, save and reopen. Check if field is still empty. Bonus: test field controlled by authorised values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127044|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127581&action=edit Bug 29334: Do not apply defaultvalue to existing auth record Note: The check in build_authorized_values_list with defaultvalue can be simplified since $value may already contain the defaultvalue. It is filled before the sub is called. The test for inserting a blank option is generalized; and may be still improved when using required attributes in the template? Note that we might experience some browser issues for these placeholders. Removed a few useless lines with respect to fields controlled by itemtypes. The last assignment to $value was useless and its probable intention unwanted (just use defaultvalue). Test plan: Put a defaultvalue in an authority framework. Add a new authority. Check for that value. Open existing authority. Clear field, save and reopen. Check if field is still empty. Bonus: test field controlled by authorised values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29334 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue where release notes| |the default value for a | |field in a framework was | |being applied when records | |were edited, rather than | |only when first created. -- You are receiving this mail because: You are watching all bug changes.