[Bug 39434] New: The pages are missing semantic tags that identify the regions of the pages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Bug ID: 39434 Summary: The pages are missing semantic tags that identify the regions of the pages. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: nina.martinez@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org "Landmarks provide an easy way for users of assistive technology understand the programmatic structure of a page and skip over content they're not interested in. For instance, if a site's header, global navigation, main content area, and footer are marked up as landmarks, a screen reader user can easily skip to the landmark they're interested in without having to work their way through all the preceding content." https://www.w3.org/WAI/WCAG21/Techniques/html/H101 Indeed, the pages do not have all the semantic tags. For example, they are missing the main and header tags. To improve accessibility, we should add more structure to the OPAC pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nina.martinez@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 --- Comment #1 from nina <nina.martinez@biblibre.com> --- Created attachment 179817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179817&action=edit Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add <main> and <header> tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 nina <nina.martinez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 --- Comment #2 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, as I fear forgetting one or more pages of the OPAC, is there any way to list : - the pages we have to test ? - the syspref and other settings to get on the staff interface ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I agree this is hard to test without a proper test plan. I tried making one but haven't managed to finish all of it (even after several hours). Here's what I have so far (I left out the numbers for each step bc it is easier to reorder if there are no numbers) To test: . Apply patch and restart_all . Enable the following system preferences - OpacBrowser - useDischarge - OPACHoldsHistory - ILLModule - OPACPrivacy - UseRecalls - ArticleRequests - OPACReportProblem - OPACVirtualCard * For each page, make sure the page looks OK and there is a main tag in the page inspector (unless noted otherwise) . Go to the OPAC (opac-main/masthead.inc - header tag in addition to main tag) . Click on 'Advanced search' (opac-advsearch) . Make a search that will return several results (e.g. shakespeare) (opac-results) . Click on a title to access the detailed record (opac-detail) . Click MARC view (opac-MARCdetail) . Click ISBD view (opac-ISBDdetail) . Click 'Place hold' (opac-reserve) . Go back to the record . Click 'Place recall' (opac-recall) . Go back to the record . Click 'Request article' (opac-request-article) . Click 'Add to your lists' (opac-addbybiblionumber) . Enter a list name . Click 'Save' . Click 'Add to your cart' . Click 'Cart' at the top of the page (opac-basket) . Click 'Send' (opac-sendbasketform) . Close the window . Close the cart window . Click the 'Comments' tab . Click 'Post your comments on this title' (opac-review) . Click on 'Course reserves' (opac-course-reserves) . Click on 'first course' (opac-course-details) . Click on 'Browse by hierarchy' (opac-browser) . Log in (if you're not already logged in, if you already are, go to Your account) (opac-user) . Click on the 'Charges' tab (opac-account) . Click on the 'Personal details' tab (opac-memberentry) . Change some information in the form . Click 'Submit update request' (opac-memberentry-update-submitted???) . Click on the 'Tags' tab (opac-tags) . Click on the 'Change password' tab (opac-passwd) . Click on the 'Search history' tab (opac-search-history) . Click on the 'Checkout history' tab (opac-readingrecord) . Click on the 'Privacy' tab (opac-privacy) . Click on the 'Holds history' tab (opac-holdshistory) . Click on the 'Recalls history' tab (opac-recalls) . Click on the 'Purchase suggestions' tab (opac-suggestions) . Click on the 'Messaging' tab (opac-messaging) . Click on the 'Lists' tab (opac-shelves) . Click on the list name . Click 'Send list' (opac-sendshelfform) . Close the window . Click on the 'Ask for discharge' tab (opac-discharge) . Click on the 'Interlibrary loan requests' tab (opac-illrequests) . Click on the 'My virtual card' tab (opac-virtual-card) . Click on 'Authority search' (opac-authorities-home) . Click on 'Submit' (opac-authoritiessearchresultlist???) . Click on 'Details' next to a result (opac-auth-detail) . Click on 'MARC view' (opac-auth-MARCdetail) . Click on 'Libraries' (opac-library) . Click on 'Report a problem' (opac-reportproblem) . Go to cgi-bin/koha/ilsdi.pl (ilsdi) . Enable OpacMaintenance . In the staff interface, go to Administration > System preferences . Search for OpacMaintenance . Set to 'Show' . Click 'Save all OPAC preferences' . Go to the OPAC (it should redirect to the maintenance page) (maintenance) This test plan is still missing all of these pages opac-account-pay-error opac-alert-subscribe opac-alert-subscriptions opac-auth opac-blocked opac-browse opac-curbside-pickups opac-downloadcart opac-downloadshelf opac-full-serial-issues opac-idref opac-imageviewer opac-issue-note opac-overdrive-search opac-page opac-password-recovery opac-patron-consent opac-registration-confirmation opac-registration-email-sent opac-registration-invalid opac-reset-password opac-restrictedpage opac-routing-lists opac-serial-issues opac-shareshelf opac-showreviews opac-tags_subject opac-topissues Fell free to rework the test plan. I don't think I will have time to finish it. As an aside, I feel like this could be easier to test if it was divided in several different bugs, but maybe I'm just too lazy... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179817|0 |1 is obsolete| | --- Comment #4 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- Created attachment 180132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180132&action=edit Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add <main> and <header> tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180132|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183004&action=edit Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add <main> and <header> tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183005&action=edit Bug 39434: (follow-up) Fix a few more instance Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Author, QA and RM: please use the git hook AND the QA script! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183363&action=edit Bug 39434: Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #9)
Created attachment 183363 [details] [review] Bug 39434: Tidy
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x For UI stability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39434 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds missing release notes| |semantic HTML5 elements, | |such as `<header>` and | |`<main>`, to the OPAC page | |structure. These changes | |improve the accessibility | |and structural clarity of | |the OPAC by explicitly | |identifying key regions of | |each page. Status|Needs documenting |RESOLVED Keywords|release-notes-needed | Resolution|--- |FIXED --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org