[Bug 7816] New: use encoding(UTF-8) not utf-8 for output streams
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Priority: P5 - low Change sponsored?: --- Bug ID: 7816 Assignee: gmcharlt@gmail.com Summary: use encoding(UTF-8) not utf-8 for output streams QA Contact: koha.sekjal@gmail.com Severity: minor Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha Setting :utf-8 on output streams flags the stream as unicode but does not ensure output is encoded as such using ':encoding(UTF-8) is the correct call. Fixed already in most files authorities/ysearch.pl reintroduces a case of not using encoding and causes make test to fail if TEST_QA is set -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 8594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8594&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8594|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8947&action=edit Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such Before the patch: % perlcritic authorities/ysearch.pl I/O layer ":utf8" used at line 38, column 1. Use ":encoding(UTF-8)" to get strict validation. (Severity: 5) After: % perlcritic authorities/ysearch.pl authorities/ysearch.pl source OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6679 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Encoding fix to authorities/ysearch.pl. Marking Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7816 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org