https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Are you referring to this page? /cgi-bin/koha/reserve/request.pl?biblionumber=X&borrowernumber=X I don't think I'm seeing the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142309&action=edit Bug 31806: Add page-section to holds tables This patch adds the page-section class to each holds view on reserve/request.pl Test plan 1) Find an biblio to test on and add holds items of different types and homebranches. 2) Work through each setting of the HoldsSplitQueue preference and confirm the page-sections appear as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I wasn't entirely sure where to put the page-section on this one.. especially given the various options for HoldsSplitQueue. At the moment, I've sectioned off each 'Split' as governed by HoldsSplitQueue.. but the argument could be made that the whole 'Existing holds' form could be a single page-section container? Also.. do the buttons look a bit crowded together for anyone else.. probabably a different bug entirely, but I think the markup there might be wrong too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. after a little more testing I decided a container around the whole existing holds section feels like it makes more sense.. second patch attached does this so you can test one after the other if you'd like to see the distinction. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31902 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31902 [Bug 31902] Inconsistent table formatting for 'Existing holds' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142309|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 142468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142468&action=edit Bug 31806: Add page-section to holds tables This patch adds the page-section class to each holds view on reserve/request.pl Test plan 1) Find an biblio to test on and add holds items of different types and homebranches. 2) Work through each setting of the HoldsSplitQueue preference and confirm the page-sections appear as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 142470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142470&action=edit Screenshots - options and display of holds page I've attached a PDF with screenshots of the options for HoldsSplitQueue. Thanks Martin for logging separate bugs for the table heading row and button placement - I've added a comment about how the light grey background continues after the buttons. Testing notes: - For item types to display: . I added an item to the record I tested this on (books) and made it a Music item type . Placed record level and item level holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142469|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142528&action=edit Bug 31806: Add page-section container to existing holds This patch adds a page-section container around the existing holds content section Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.