[Bug 18611] New: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Bug ID: 18611 Summary: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On the manage marc import screen, clicking Import Batch on a batch containing a deleted item gives the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details.", and creates an empty PDF file. To replicate: 1) Import a marc record including items. 2) Delete one of the items in the batch. 3) In Home › Tools › Manage staged MARC records, click '(Create label batch)' on the batch in question. 4) This will show the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details." The logs in /var/log/koha/INSTANCE/intranet-error.log will look like this: 123456 [Mon May 15 11:14:21.848772 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) [for Statement "INSERT INTO creator_batches (batch_id, item_number, branch_code, creator) VALUES (?,?,?,?);" with ParamValues: 0=164, 1=123456, 2="APL", 3='Labels'] at /usr/share/koha/lib/C4/Creators/Batch.pm line 69., referer: http://asdfsadf... [Mon May 15 11:14:21.849012 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: Database returned the following error on attempted INSERT: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) at /usr/share/koha/lib/C4/Creators/Batch.pm line 71., referer: http://asdfsadf... [Mon May 15 11:14:21.849147 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: create_labelbatch_from_importbatch() : Error attempting to add item #123456 of import batch #11048 to label batch. at /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl line 198., referer: http://asdfsadf ... I think we need to have /usr/share/koha/lib/C4/Creators/Batch.pm exclude items where the itemnumber is null. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- As a work-around, create a report of valid barcodes in a given import batch using the query found here: https://wiki.koha-community.org/wiki/SQL_Reports_Library#Workaround_for_Bug_... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63483&action=edit Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63483|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63667&action=edit Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63668&action=edit [SIGNED-OFF] Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63668|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63669&action=edit Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63667|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 63728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63728&action=edit Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. To test: 1 - Import a batch with some items 2 - Delete one of the imported items 3 - Browse to Tools->Staged MARC record management 4 - Click (Create label batch) for the batch you imported 5 - Recieve an error 6 - Apply patch 7 - Click (Create label batch) 8 - Batch is created with remaning items from the import Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63669|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 63729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63729&action=edit Bug 18611 - Followup, remove tabs to make qa tools happy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 63730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63730&action=edit Bug 18611: [QA Follow-up] Make SQL query more readable Make it more explicit by adding join statements. Test plan: See next patch for adding a unit test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 63731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63731&action=edit Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch Test plan: Run t/db_dependent/ImportBatch.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |nick@bywatersolutions.com |u | CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick, Josef, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Create labels action fails |Create labels action fails |in manage-marc-import.pl if |in manage-marc-import.pl if |an item has been deleted |an item has been deleted |from the import batch. |from the import batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org