[Bug 42359] New: t/db_dependent/Reports/Guided.t fails when ReportsLog is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Bug ID: 42359 Summary: t/db_dependent/Reports/Guided.t fails when ReportsLog is enabled Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: nick@bywatersolutions.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When ReportsLog is enabled, one gets this failure on Koha main: t/db_dependent/Reports/Guided.t .. 8/14 # Failed test 'no warnings' # at /usr/share/perl/5.36/Test/Builder.pm line 193. # There were 1 warning(s) # Previous test 9 'Without id delete_report returns undef' # Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Reports/Guided.pm line 798. # at /kohadevbox/koha/C4/Reports/Guided.pm line 798. # C4::Reports::Guided::delete_report(1) called at t/db_dependent/Reports/Guided.t line 263 # main::__ANON__() called at /usr/share/perl/5.36/Test/Builder.pm line 374 # eval {...} called at /usr/share/perl/5.36/Test/Builder.pm line 374 # Test::Builder::subtest(Test::Builder=HASH(0xaaab107f82d0), "get_saved_reports", CODE(0xaaab1b732660)) called at /usr/share/perl/5.36/Test/More.pm line 809 # Test::More::subtest("get_saved_reports", CODE(0xaaab1b732660)) called at t/db_dependent/Reports/Guided.t line 325 # # Looks like you failed 1 test of 14. t/db_dependent/Reports/Guided.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/14 subtests Test Summary Report ------------------- t/db_dependent/Reports/Guided.t (Wstat: 256 (exited 1) Tests: 14 Failed: 1) Failed test: 14 Non-zero exit status: 1 Files=1, Tests=14, 2 wallclock secs ( 0.01 usr 0.00 sys + 0.95 cusr 0.23 csys = 1.19 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 --- Comment #1 from Casey Conlin - mattermost @Casey246 <casey.conlin@gmail.com> --- Created attachment 197363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197363&action=edit Fix Guided.t update_sql test input The test was feeding update_sql object field names instead of the parameter names it actually expects. This let savedsql get cleared during the update. The test was updated to pass the expected inputs so it still checks cache_expiry without creating the warning in the delete log path. Test plan: 1. Confirm the issue by enabling the ReportsLog preference in Koha UI andin ktd shell running prove t/db_dependent/Reports/Guided.t 2. Apply the patch. 3. Run the tests again with prove t/db_dependent/Reports/Guided.t 4. The tests should pass. 5. Disable the preference and run again. 6. Tests should pass. 7. Sign off if steps above check out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Casey Conlin - mattermost @Casey246 <casey.conlin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |casey.conlin@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197364&action=edit Fix Guided.t update_sql test input The test was feeding update_sql object field names instead of the parameter names it actually expects. This let savedsql get cleared during the update. The test was updated to pass the expected inputs so it still checks cache_expiry without creating the warning in the delete log path. Test plan: 1. Confirm the issue by enabling the ReportsLog preference in Koha UI andin ktd shell running prove t/db_dependent/Reports/Guided.t 2. Apply the patch. 3. Run the tests again with prove t/db_dependent/Reports/Guided.t 4. The tests should pass. 5. Disable the preference and run again. 6. Tests should pass. 7. Sign off if steps above check out. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |casey.conlin@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197786&action=edit Bug 42359: Fix Guided.t update_sql test input The test was feeding update_sql object field names instead of the parameter names it actually expects. This let savedsql get cleared during the update. The test was updated to pass the expected inputs so it still checks cache_expiry without creating the warning in the delete log path. Test plan: 1. Confirm the issue by enabling the ReportsLog preference in Koha UI andin ktd shell running prove t/db_dependent/Reports/Guided.t 2. Apply the patch. 3. Run the tests again with prove t/db_dependent/Reports/Guided.t 4. The tests should pass. 5. Disable the preference and run again. 6. Tests should pass. 7. Sign off if steps above check out. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.05 |26.05.00,25.11.05,25.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Attachment #197364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42359 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is minor, I dont backport to 24.11 LTS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org