[Bug 35249] New: Use DataTables RowReorder extension instead of tableDND jQuery plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Bug ID: 35249 Summary: Use DataTables RowReorder extension instead of tableDND jQuery plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 34913 I think it makes sense to replace jquery.tablednd.js with DataTables "official" extension RowReorder: https://datatables.net/extensions/rowreorder/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Bug 35249 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Bug 35249 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163598&action=edit Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163599&action=edit Bug 35249: Adjust table id and style We could eventually have a table for authorities, so better to have a specific table id. Also I think it's better to have the table smaller than taking the whole width Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163600&action=edit Bug 35249: Remove tableDnD from the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Talked with Owen and we wrote more or less the same patch (his was working however! Mine was missing the hidden column which didn't make the reorder works correctly). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163601&action=edit Bug 35249: Remove sort indicator on th -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35138 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138 [Bug 35138] Elastic search - add new facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163598|0 |1 is obsolete| | Attachment #163599|0 |1 is obsolete| | Attachment #163600|0 |1 is obsolete| | Attachment #163601|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164795&action=edit Bug 35249: Use DataTables RowReorder extension instead of tableDND jQuery plugin Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164796&action=edit Bug 35249: Adjust table id and style We could eventually have a table for authorities, so better to have a specific table id. Also I think it's better to have the table smaller than taking the whole width Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164797&action=edit Bug 35249: Remove tableDnD from the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164798&action=edit Bug 35249: Remove sort indicator on th Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Bug 35249 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed a conflict in the about page and followed-up on a QA script failure: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 12) forbidden pattern: Do *not* include full path to css files, use the Asset TT plugin (bug 20538) (line 12) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35249 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org