[Bug 24952] New: Refund modal confirm button should have an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Bug ID: 24952 Summary: Refund modal confirm button should have an ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, katrin.fischer@bsz-bw.de, koha-bugs@lists.koha-community.org, mark.gavillet@ptfs-europe.com, martin.renvoize@ptfs-europe.com, sally.healey@cheshiresharedservices.gov.uk, testopia@bugs.koha-community.org, tomascohen@gmail.com Depends on: 23442 Blocks: 13985 Sometimes people wish to override the refund confirmation button, for example, to open a cash register via JS.. as such it's helpful to have an ID for the button. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101436&action=edit Bug 24952: Add id to refund modals confirm buttons This patch adds an ID to the refund confirmation modals for both borrower account and point of sale register details pages. Test plan: 1/ Apply patch 2/ Attempt to issue a refund to a patron 3/ Inspect the page and note the presence of an ID for the confirm button, 4/ Attempt to issue a refund via point of sale register details page 5/ Inspect the page and note the presence of an ID for the confirm button. 6/ Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24951 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101436|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 101444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101444&action=edit Bug 24952: Add id to refund modals confirm buttons This patch adds an ID to the refund confirmation modals for both borrower account and point of sale register details pages. Test plan: 1/ Apply patch 2/ Attempt to issue a refund to a patron 3/ Inspect the page and note the presence of an ID for the confirm button, 4/ Attempt to issue a refund via point of sale register details page 5/ Inspect the page and note the presence of an ID for the confirm button. 6/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101444|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 101451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101451&action=edit Bug 24952: Add id to refund modals confirm buttons This patch adds an ID to the refund confirmation modals for both borrower account and point of sale register details pages. Test plan: 1/ Apply patch 2/ Attempt to issue a refund to a patron 3/ Inspect the page and note the presence of an ID for the confirm button, 4/ Attempt to issue a refund via point of sale register details page 5/ Inspect the page and note the presence of an ID for the confirm button. 6/ Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24952 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org