[Bug 32968] New: Create granular permissions for ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Bug ID: 32968 Summary: Create granular permissions for ERM Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: pedro.amorim@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 32925 Currently, there is only one top-level permission for ERM on the system. Example: Allow a staff member to create agreements but not delete them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 [Bug 32925] Display loading info when a form is submitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Currently, there is only one top-level permission for ERM on the system. There should be granular permissions, example: Allow a staff member to create agreements but not delete them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32971 [Bug 32971] Access to ERM module requires 'erm' permission and 'vendors_manage' acquisition sub-permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32971 | Depends on| |32971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32971 [Bug 32971] Access to ERM module requires 'erm' permission and 'vendors_manage' acquisition sub-permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146698&action=edit Bug 32968: (WIP) Create granular permissions for ERM This is just a work in progress but open for discussion if anyone has any input, ideally would like to have a wildcard for erm subpermissions on x-koha-authorization paths but as it stands the way I found that works is listing all sub-permissions (idea is to give read access to agreements even if user only has 'manage_licenses' permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |pedro.amorim@ptfs-europe.co |com |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What are the real-life use cases we are trying to solve here? Maybe we are reproducing a wrong pattern with this approach (having all the different permissions) and we should prefer something else. We could have permissions that represent jobs in a library. erm-admin - allow read/write access to everything erm-show - only read erm-licensing - read/write to license and read on related resources (we will face the problem of the patron search permission) erm-agreement - read/write agreements, and read licenses erm-eholdings - read/write eholdings, and read agreements and a special one for ebsco? Does it answer the different needs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #3)
What are the real-life use cases we are trying to solve here?
Maybe we are reproducing a wrong pattern with this approach (having all the different permissions) and we should prefer something else. We could have permissions that represent jobs in a library.
I've long wanted to impliment a roles based access control system.. problem is I don't think a developer can define what permissions a role requires.. different libraries see different roles meaning different things. In my rebus:list days, we had very granular flags for each operation that could take place and then we had a role builder interface that allowed admins to create their roles and assign those granular permissions to them.. then end users were granted one or more roles on the system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146698|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147466&action=edit Bug 32968: (WIP) Create granular permissions for ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- POC for permissions implementation in agreements. Opinions welcome! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Yes, this looks good to me. One suggestion is to move the "OR" logic in the template Pass permission.agreement = permissions.admin || permissions.agreement ? 1 : 0 And simply test permission.agreement later you could also have + permissions.admin || + permissions.agreement || + permissions.show in show_agreement? Or... ... generate a hash like (pseudo-code): { agreement => { read => { permissions.admin || permissions.agreement || permissions.show } write => { permissions.admin || permissions.agreement } } } Then simply test for agreement.read and agreement.write? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147466|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147510&action=edit Bug 32968: ERM granular permissions - Preparation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147511&action=edit Bug 32968: ERM granular permissions - DB specific -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147513&action=edit Bug 32968: ERM granular permissions - API specs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147514&action=edit Bug 32968: ERM granular permissions - Licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147515&action=edit Bug 32968: ERM granular permissions - Agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147516&action=edit Bug 32968: ERM granular permissions - EHoldings Packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147517&action=edit Bug 32968: ERM granular permissions - EHoldings Titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147518&action=edit Bug 32968: ERM granular permissions - Navigation guards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147511|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 147559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147559&action=edit Bug 32968: ERM granular permissions - DB specific -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Preparation: * Apply patch and reset_all * Enable ERMModule sys pref * Create a new patron John (staff) with only catalogue, acquisitions and borrowers permissions (these last 2 are required for ERM, for now, see bug 32971) Test plan - show: * Add only the erm_show permission to John * Login as John * Verify that John has read-only access to all ERM, but cannot create edit or delete anything Test plan - admin: * Add only the erm_admin permission to John * Login as John * Verify that all ERM CRUD is available Test plan - licenses: * Add only the erm_licensing permission to John * Login as John * Verify that only licenses are available in the menu and that accessing directly to /cgi-bin/koha/erm/agreements will redirect to erm homepage Test plan - agreements: * Add only the erm_agreement permission to John * Login as John * Verify that side menu has all content available * Verify that John can create edit and delete agreements * Verify that John can only read licenses and accessing /cgi-bin/koha/erm/licenses/add will redirect to erm homepage * Verify that John can only read eHoldings and accessing /cgi-bin/koha/erm/eholdings/local/titles/add will redirect to erm homepage Test plan - eholdings: * Add only the erm_eholdings permission to John * Login as John * Verify that side menu has all content available except licenses * Verify that John can create edit and delete eholdings titles and packages * Verify that John can only read agreements and accessing /cgi-bin/koha/erm/agreements/add will redirect to erm homepage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33106 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 [Bug 33106] Add vendor link to ERM Licences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This could use some cypress tests to go along with, we would have to create a patron with the necessary permissions for testing beforeEach test, and delete said patron afterEach test. Discussing with Jonathan 2 options seem reasonable: 1) By POSTing and DELETEIng the patron - this would require the addition of a REST endpoint for permissions 2) Use cypress to click through the UI to create the patron, do the same thing to remove. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Bug 32968 depends on bug 32925, which changed state. Bug 32925 Summary: Display loading info when a form is submitted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This does not apply, please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147510|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148797&action=edit Bug 32968: ERM granular permissions - Preparation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147513|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148798&action=edit Bug 32968: ERM granular permissions - API specs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147514|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148799&action=edit Bug 32968: ERM granular permissions - Licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147515|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148800&action=edit Bug 32968: ERM granular permissions - Agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147516|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148801&action=edit Bug 32968: ERM granular permissions - EHoldings Packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147517|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148802&action=edit Bug 32968: ERM granular permissions - EHoldings Titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147518|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148803&action=edit Bug 32968: ERM granular permissions - Navigation guards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147559|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 148804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148804&action=edit Bug 32968: ERM granular permissions - DB specific -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148797|0 |1 is obsolete| | --- Comment #28 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148959&action=edit Bug 32968: ERM granular permissions - Preparation Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148798|0 |1 is obsolete| | --- Comment #29 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148960&action=edit Bug 32968: ERM granular permissions - API specs Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148799|0 |1 is obsolete| | --- Comment #30 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148961&action=edit Bug 32968: ERM granular permissions - Licenses Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148800|0 |1 is obsolete| | --- Comment #31 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148962&action=edit Bug 32968: ERM granular permissions - Agreements Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148801|0 |1 is obsolete| | --- Comment #32 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148963&action=edit Bug 32968: ERM granular permissions - EHoldings Packages Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148802|0 |1 is obsolete| | --- Comment #33 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148964&action=edit Bug 32968: ERM granular permissions - EHoldings Titles Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148803|0 |1 is obsolete| | --- Comment #34 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148965&action=edit Bug 32968: ERM granular permissions - Navigation guards Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148804|0 |1 is obsolete| | --- Comment #35 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148966&action=edit Bug 32968: ERM granular permissions - DB specific Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact| |katrin.fischer@bsz-bw.de --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pedro, can you please clean these up? OK api/v1/swagger/paths/erm_agreements.yaml OK api/v1/swagger/paths/erm_documents.yaml OK api/v1/swagger/paths/erm_eholdings_packages.yaml OK api/v1/swagger/paths/erm_eholdings_packages_resources.yaml OK api/v1/swagger/paths/erm_eholdings_resources.yaml OK api/v1/swagger/paths/erm_eholdings_titles.yaml OK api/v1/swagger/paths/erm_eholdings_titles_resources.yaml OK api/v1/swagger/paths/erm_licenses.yaml OK api/v1/swagger/paths/erm_users.yaml OK erm/erm.pl FAIL installer/data/mysql/atomicupdate/bug_32968.pl FAIL file permissions File must have the exec flag OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc FAIL koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt FAIL filters missing_filter at line 49 ( write: [% CAN_user_erm_erm_licensing || CAN_user_erm_erm_admin ? 1 : 0 %],) missing_filter at line 50 ( read: [% CAN_user_erm_erm_licensing || CAN_user_erm_erm_admin || CAN_user_erm_erm_show || CAN_user_erm_erm_agreement ? 1 : 0 %],) missing_filter at line 53 ( write: [% CAN_user_erm_erm_agreement || CAN_user_erm_erm_admin ? 1 : 0 %],) missing_filter at line 54 ( read: [% CAN_user_erm_erm_agreement || CAN_user_erm_erm_admin || CAN_user_erm_erm_show || CAN_user_erm_erm_eholdings ? 1 : 0 %],) missing_filter at line 57 ( write: [% CAN_user_erm_erm_eholdings || CAN_user_erm_erm_admin ? 1 : 0 %],) missing_filter at line 58 ( read: [% CAN_user_erm_erm_eholdings || CAN_user_erm_erm_admin || CAN_user_erm_erm_show || CAN_user_erm_erm_agreement ? 1 : 0 %],) OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148959|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149423&action=edit Bug 32968: ERM granular permissions - Preparation Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148960|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149424&action=edit Bug 32968: ERM granular permissions - API specs Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148966|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149425&action=edit Bug 32968: ERM granular permissions - DB specific Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148961|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149426&action=edit Bug 32968: ERM granular permissions - Licenses Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148962|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149427&action=edit Bug 32968: ERM granular permissions - Agreements Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148963|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149428&action=edit Bug 32968: ERM granular permissions - EHoldings Packages Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148964|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149429&action=edit Bug 32968: ERM granular permissions - EHoldings Titles Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148965|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149430&action=edit Bug 32968: ERM granular permissions - Navigation guards Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #45 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thank you Katrin. Rebased this as it no longer applied nicely. QA script seems happy now, please confirm. Test plan remains the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. Should we restrict access to the whole ERM module is vendor_manage is not set? 2. I can list agreements even if I have only erm_eholdings. It's confusing as we don't have access to "Licenses". 3. EBSCO Add to/Remove from holdings buttons should be removed with only erm_show 4. Same for "Add new agreement" on EBSCO pkg show view 5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with only erm_show (same for agreement) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that you should certain rebase on top of bug 33483, here is how I fixed the conflict: 130 actions: { 131 0: ["show"], 132 ...((permissions.agreement.write || this.embedded) && { 133 "-1": this.embedded 134 ? [ 135 { 136 select: { 137 text: this.$__("Select"), 138 icon: "fa fa-check", 139 }, 140 }, 141 ] 142 : ["edit", "delete"], 143 }), 144 }, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #46)
5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with only erm_show (same for agreement)
Not sure we should consider this blocker, does not seem trivial to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This wasn't applying. Rebased. It's even worse now. After bug 33408, the staff user also requires the permission parameters in order to be able to fetch the ERMModule syspref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149423|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150060&action=edit Bug 32968: ERM granular permissions - Preparation Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149424|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150061&action=edit Bug 32968: ERM granular permissions - API specs Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149425|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150062&action=edit Bug 32968: ERM granular permissions - DB specific Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149426|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150063&action=edit Bug 32968: ERM granular permissions - Licenses Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149427|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150064&action=edit Bug 32968: ERM granular permissions - Agreements Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149428|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150065&action=edit Bug 32968: ERM granular permissions - EHoldings Packages Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149429|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150066&action=edit Bug 32968: ERM granular permissions - EHoldings Titles Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149430|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150067&action=edit Bug 32968: ERM granular permissions - Navigation guards Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #58 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #46)
1. Should we restrict access to the whole ERM module is vendor_manage is not set? I don't know :) Also, see comment #49
2. I can list agreements even if I have only erm_eholdings. It's confusing as we don't have access to "Licenses". It's working as intented. I followed your suggestion on comment #3, to me it makes sense because eHoldings may be related to agreements, but not licenses. Either way, I'm open to suggestions about this, should eHoldings write permission give read-only permission to both agreements+licenses?
3. EBSCO Add to/Remove from holdings buttons should be removed with only erm_show 4. Same for "Add new agreement" on EBSCO pkg show view Yes, thanks! I missed EBSCO permissions in these patches. Will provide patches for this when I find the time.
5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with only erm_show (same for agreement) You don't get an error, you are redirected to /cgi-bin/koha/erm/erm.pl. If this is what you are experiencing, do you think it would be preferable to show an error page instead? (I don't think this is important, this is just a permission double-check in case the user attempts to access content that he doesn't have permission to, directly through the URL). Error or not, user doesn't have access to the content he's not permitted to.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Pedro Amorim from comment #49)
This wasn't applying. Rebased. It's even worse now. After bug 33408, the staff user also requires the permission parameters in order to be able to fetch the ERMModule syspref.
Yes, we noticed that with Tomas last week. We need to fix that before anything else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #59)
(In reply to Pedro Amorim from comment #49)
This wasn't applying. Rebased. It's even worse now. After bug 33408, the staff user also requires the permission parameters in order to be able to fetch the ERMModule syspref.
Yes, we noticed that with Tomas last week. We need to fix that before anything else.
Reported on bug 33606. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33606 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #61 from Mathieu Saby <mathsabypro@gmail.com> --- Hello Do you still plan to create more granular permission for the module? Would you need feedback from libraries? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #62 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Mathieu Saby from comment #61)
Hello Do you still plan to create more granular permission for the module? Would you need feedback from libraries?
Hi Mathieu, Unfortunately this fell off in our priorities, and the blockers I found at the time caused this development to get stuck. I know that some of these blockers have since been solved, but I don't know what else may be required here. We don't have plans to revisit this in the immediate future, but may come back to it at some point, particularly if there is funding available to help us get this over the finish line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #63 from Mathieu Saby <mathsabypro@gmail.com> --- It's essential to distinguish between "reading" and everything else. Ideally, this "else" could be divided into different granular operations, but that seems less important to me, and it can become complicated to manage given the way Koha manages (inconveniently) permissions. So, my personal opinion: we could have the following permissions : - erm-show-agreement : to display agreements - erm-manage-agreement : to add, edit, delete agrements - erm-show-licence : to display licence - erm-manage-licence : to add, edit, delete licence - erm-show-eholdings : to display packages and titles (local and Ebsco) - erm-manage-eholdings : to add, edit, delete packages and titles (local and Ebsco), including import from kbart and lists - erm-show-datasources - erm-manage-datasources - erm-harvest-datasources : test sushi connexion, harvest with sushi, import Counter reports manually - erm-show-reports - erm-manage-reports - erm-run-reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #64 from Mathieu Saby <mathsabypro@gmail.com> --- (I made an exception for erm-harvest-datasources and erm-run-reports ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40684 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org