[Bug 24996] New: Unwanted CSS change unhides OPAC results sorting button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Bug ID: 24996 Summary: Unwanted CSS change unhides OPAC results sorting button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 23915 With JavaScript enabled the "Go" button associated with the OPAC search results re-sort form should be hidden. Looks like I accidentally removed a line of CSS with Bug 23915 which needs to get put back. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915 [Bug 23915] Replace OPAC list sort menu with Bootstrap menu button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 101995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101995&action=edit Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101995|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 102046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102046&action=edit Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102046|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102117&action=edit Bug 24996: Unwanted CSS change unhides OPAC results sorting button This patch adds back a CSS selector which was incorrectly removed by Bug 23915. The "Go" button associated with the OPAC search results resort operation should be hidden if JavaScript is enabled. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Perform a search in the OPAC - On the search results page, there should be no "Go" button next to the re-sort/results per page selection fields. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24996 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- missing dependencies - not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org