[Bug 19669] New: Remove deprecated report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Bug ID: 19669 Summary: Remove deprecated report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Koha has a report which isn't linked to from anywhere. A comment on Bug 840 says that the report is deprecated. I propose that thirteen years is enough of a wait and we should probably go ahead and remove it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Summary|Remove deprecated report |Remove deprecated checkouts | |by patron category report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69246&action=edit Bug 19669: Remove deprecated checkouts by patron category report The checkouts by patron category report has been hidden and considered deprecated since 2004. This patch removes it. To test, apply the patch and confirm that nothing at all seems to have changed and everything feels fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69246|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 69406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69406&action=edit Bug 19669: Remove deprecated checkouts by patron category report Patch applies. Reports and general OPAC and staff client functionality is intact. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3431 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 19668 has been marked as a duplicate of this bug. *** --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 19667 has been marked as a duplicate of this bug. *** --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 19666 has been marked as a duplicate of this bug. *** --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 19665 has been marked as a duplicate of this bug. *** --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about the other .plugin file (reports/itemtypes.plugin), see bug 3431 comment 2. And then remove reports/manager.pl? Is this plugin system used? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69406|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70029&action=edit Bug 19669: Remove deprecated checkouts by patron category report Patch applies. Reports and general OPAC and staff client functionality is intact. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70030&action=edit Bug 19669 [QA Followup] - Remove itemstypes.plugin Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #9)
Created attachment 70030 [details] [review] Bug 19669 [QA Followup] - Remove itemstypes.plugin
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Kyle, Are you sure about that? If yes we should remove it on a specific bug report, as well as the reports/manager.pl stuffs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #14 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Link for reports/itemtypes.plugin is stil in staff:/cgi-bin/koha/reports/reports-home.pl with the name "Catalog by itemtype" New bug for this or do we use the current one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #14)
Link for reports/itemtypes.plugin is stil in staff:/cgi-bin/koha/reports/reports-home.pl with the name "Catalog by itemtype"
New bug for this or do we use the current one?
I'd say new bug since this one has been released. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20092 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #10)
(In reply to Kyle M Hall from comment #9)
Created attachment 70030 [details] [review] [review] Bug 19669 [QA Followup] - Remove itemstypes.plugin
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Kyle, Are you sure about that? If yes we should remove it on a specific bug report, as well as the reports/manager.pl stuffs.
Oops, I forgot to remove this commit before the push, I am going to revert it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #16)
(In reply to Jonathan Druart from comment #10)
(In reply to Kyle M Hall from comment #9)
Created attachment 70030 [details] [review] [review] [review] Bug 19669 [QA Followup] - Remove itemstypes.plugin
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Kyle, Are you sure about that? If yes we should remove it on a specific bug report, as well as the reports/manager.pl stuffs.
Oops, I forgot to remove this commit before the push, I am going to revert it.
Reverted last patch for stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens from comment #17)
Reverted last patch for stable for 17.11.03
Same for 17.05 then, reverted in v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 --- Comment #19 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Just for anyone else who might have also a doubt: it's indeed reverted in master (commit 7cb86656956131ed81cc74069a765a37664edd8e) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 20368 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org