[Bug 21205] New: C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Bug ID: 21205 Summary: C4::Acquisition - Remove GetOrderFromItemnumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 [Bug 21204] Move C4::Acquisition code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15184 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha::Acquisition::Order->items comes from bug 15184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 [Bug 15184] Ability to duplicate existing order lines to a given basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77698&action=edit Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77698|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 78042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78042&action=edit Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 78043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78043&action=edit Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- perl t/db_dependent/Acquisition/CancelReceipt.t 1..12 The method Koha::Acquisition::Order->items is not covered by tests! perl t/db_dependent/Acquisition/TransferOrder.t 1..13 ok 1 - 1 order in basket1 The method Koha::Acquisition::Order->items is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha::Acquisition::Order->items is added by bug 15184 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78042|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78319&action=edit Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78043|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78320&action=edit Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Acquisition - Remove |[DEP_15184] C4::Acquisition |GetOrderFromItemnumber |- Remove | |GetOrderFromItemnumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passed QA but note that 15184 is in FQA now. Please wait, RM. Added a temporary flag in the title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Bug 21205 depends on bug 21202, which changed state. Bug 21202 Summary: C4::Items - Remove GetItemsByBiblioitemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEP_15184] C4::Acquisition |C4::Acquisition - Remove |- Remove |GetOrderFromItemnumber |GetOrderFromItemnumber | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Bug 21205 depends on bug 15184, which changed state. Bug 15184 Summary: Ability to duplicate existing order lines to a given basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 [Bug 22360] On order information missing in OPAC normal display -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org