[Bug 16249] New: Zebra-specific tests should pass with ES disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Bug ID: 16249 Summary: Zebra-specific tests should pass with ES disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com To reproduce: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 50157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50157&action=edit Bug 16249: Zebra-specific tests should pass with ES disabled This patch makes the t/db_dependent/Search.t tests correctly set 'Zebra' for the 'SearchEngine' syspref. To test: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: Tests now pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50157|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 50160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50160&action=edit Bug 16249: Zebra-specific tests should pass with ES disabled This patch makes the t/db_dependent/Search.t tests correctly set 'Zebra' for the 'SearchEngine' syspref. To test: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: Tests now pass. Signed-off-by: Chris <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50160|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50762&action=edit [PASSED QA] Bug 16249: Zebra-specific tests should pass with ES disabled This patch makes the t/db_dependent/Search.t tests correctly set 'Zebra' for the 'SearchEngine' syspref. To test: - On top of bug 12478 branch, run $ prove t/db_dependent/Search.t => FAIL: Tests fail - Apply the patch - Run: $ prove t/db_dependent/Search.t => SUCCESS: Tests now pass. Signed-off-by: Chris <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51297&action=edit Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51297|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Comment on attachment 51297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51297 Bug 16469 - Remove the use of "onclick" from some catalog pages Sorry, git-bz typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16249 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org