[Bug 23102] New: 404 errors on page causes SCI user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Bug ID: 23102 Summary: 404 errors on page causes SCI user to be logged out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 18387, but for the SCI To recreate: 1 - Have something on the SCO page that won't load 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 4 - Sign in 5 - Click 'Finish' 6 - Yes to print a receipt 7 - You are asked to sign in again 8 - Repeat with the SCI module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90528&action=edit Bug 23102 - 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 4 - Sign in 5 - Click 'Finish' 6 - Yes to print a receipt 7 - You are asked to sign in again 8 - Repeat with the SCI module 9 - Apply patch 10 - Repeat, but this time the slip can be printed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 [Bug 18387] 404 errors on page causes SCO user to be logged out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #1)
Created attachment 90528 [details] [review] Bug 23102 - 404 errors on page causes SCI user to be logged out
To test: 1 - Have something on the SCO page that won't load
Can you be more specific? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
(In reply to Nick Clemens from comment #1)
Created attachment 90528 [details] [review] [review] Bug 23102 - 404 errors on page causes SCI user to be logged out
To test: 1 - Have something on the SCO page that won't load
Can you be more specific?
Add to SCOUserJS: </script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script> You need to ask for something local that will return the Koha 404 page This happens all the time in 18.11, related to new SCSS changes that were not fully backported, we ask for the wrong icons - see bug 23198 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It would be great to have a regression selenium test here, do not you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90528|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97581&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 4 - Sign in 5 - Click 'Finish' 6 - Yes to print a receipt 7 - You are asked to sign in again 8 - Repeat with the SCI module 9 - Apply patch 10 - Repeat, but this time the slip can be printed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
It would be great to have a regression selenium test here, do not you think?
This works for me, but should it be 'Failed QA' because of the missing test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #6)
(In reply to Jonathan Druart from comment #4)
It would be great to have a regression selenium test here, do not you think?
This works for me, but should it be 'Failed QA' because of the missing test?
Changing status. Please correct if you want to sign off on this patch and add your signoff line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98977&action=edit Bug 23102: Add fieldset to login for selenium usage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98978&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- The behaviour does still recur and can be fixed by this patch, however, I can't make the selenium tests fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #10)
The behaviour does still recur and can be fixed by this patch, however, I can't make the selenium tests fail
What are you using in the pref? Using what you used in the tests I am not able to recreate the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is an evil bug.. very easy to hit at upgrades and have absolutely no idea what's triggering the behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- We still face this problem, while it is difficult to recreate in testing, in production this happens and the code is simple and self explanatory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hayleypelham@catalyst.net.n | |z --- Comment #14 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97581|0 |1 is obsolete| | Attachment #98977|0 |1 is obsolete| | Attachment #98978|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148423&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 4 - Sign in 5 - Click 'Finish' 6 - Yes to print a receipt 7 - You are asked to sign in again 8 - Repeat with the SCI module 9 - Apply patch 10 - Repeat, but this time the slip can be printed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148424&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148424|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148425&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148425|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148426&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Rebased, it now works - tests fail with out the patch, they succeed with the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148601&action=edit Bug 23102: Fix tests # Failed test 'No tests run for subtest "SCI can load error pages"' # at t/db_dependent/selenium/regressions.t line 86. Too many forms are displayed. Cannot submit. at /kohadevbox/koha/t/lib/Selenium.pm line 140. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The tests were failing, I fixed them. But now they are passing with and without the fix. Can you have another look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148423|0 |1 is obsolete| | Attachment #148426|0 |1 is obsolete| | Attachment #148601|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148767&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148768&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 4 - Sign in 5 - Click 'Finish' 6 - Yes to print a receipt 7 - You are asked to sign in again 8 - Repeat with the SCI module 9 - Apply patch 10 - Repeat, but this time the slip can be printed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #21)
The tests were failing, I fixed them. But now they are passing with and without the fix. Can you have another look please?
Yes, the problem was that the page does load, but you are kicked out after - so we need to load, submit, then see we are logged out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #25 from Magnus Enger <magnus@libriotech.no> --- I can't reproduce the problem in ktd. I put this: </script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script> in SCOUserJS, restarted all the things and logged into SCO, then clicked "Finished", "Print receipt and end session" and could print the receipt without getting logged out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33881 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Magnus Enger from comment #25)
I can't reproduce the problem in ktd. I put this:
</script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script>
in SCOUserJS, restarted all the things and logged into SCO, then clicked "Finished", "Print receipt and end session" and could print the receipt without getting logged out.
Yes, it seems we 'fixed' this problem, but if we fix bug 33881 it will reintroduce this issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #27 from David Cook <dcook@prosentient.com.au> --- I'm short on time at the moment, but if someone signs this off, and I could look at QAing it perhaps next week... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #28 from Magnus Enger <magnus@libriotech.no> --- (In reply to Nick Clemens from comment #26)
Yes, it seems we 'fixed' this problem, but if we fix bug 33881 it will reintroduce this issue
Does the test plan still make sense, or is there something else to look out for? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148767|0 |1 is obsolete| | Attachment #148768|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154691&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154692&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load 2 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 3 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 4 - Sign in using a patron 5 - Enter an unkown barcode, I used "DONTMATTER" 6 - If not logged out, click to 'Return to account summary' 7 - You are asked to sign in again 8 - Repeat with the SCI module 9 - Apply patch 10 - Repeat, but this time you can return to account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Magnus Enger from comment #28)
Does the test plan still make sense, or is there something else to look out for?
Updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from David Cook <dcook@prosentient.com.au> --- I'm getting an error when I try running the selenium test. root@kohadevbox:koha(bug_23102)$ prove t/db_dependent/selenium/regressions.t t/db_dependent/selenium/regressions.t .. # Failed test at t/db_dependent/selenium/regressions.t line 87. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. # 'Log in to your account › Koha online catalog' # doesn't match '(?^u:Self check-in)' # Looks like you failed 1 test of 1. t/db_dependent/selenium/regressions.t .. 1/9 # Failed test 'SCI can load error pages' # at t/db_dependent/selenium/regressions.t line 92. t/db_dependent/selenium/regressions.t .. 7/9 Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. t/db_dependent/selenium/regressions.t .. 9/9 # Looks like you failed 1 test of 9. t/db_dependent/selenium/regressions.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- t/db_dependent/selenium/regressions.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=9, 51 wallclock secs ( 0.03 usr 0.01 sys + 3.94 cusr 0.58 csys = 4.56 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- Test plan missing some steps like enabling "SelfCheckInModule" and how to "have something on the SCO page that won't load". I used "SelfCheckInMainUserBlock" with <img src="x"> for the self-checkin. I can't get the AutoSelfCheck user to log into the self checkin it seems? Is it supposed to be? But I think the patch is working? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on|33881 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154691|0 |1 is obsolete| | Attachment #154692|0 |1 is obsolete| | --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163358&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163359&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load Add to SCOUserJS: </script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script> 2 - Enable the SCO and SCI system preferences: WebBasedSelfCheck: Enable SelfCheckInModuke: Enable AutoSelfCheckAllowed: Allow AutoSelfCheckID / AutoSelfCheckPass to a valid user with permissions 3 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 4 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 5 - Sign in using a patron 6 - Enter an unkown barcode, I used "DONTMATTER" 7 - If not logged out, click to 'Return to account summary' 8 - You are asked to sign in again 9 - Repeat with the SCI module 10 - Apply patch 11 - Repeat, but this time you can return to account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Why are we loosing track of things during years? Should we buy a brain to share? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163359|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164591&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load Add to SCOUserJS: </script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script> 2 - Enable the SCO and SCI system preferences: WebBasedSelfCheck: Enable SelfCheckInModuke: Enable AutoSelfCheckAllowed: Allow AutoSelfCheckID / AutoSelfCheckPass to a valid user with permissions 3 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 4 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 5 - Sign in using a patron 6 - Enter an unkown barcode, I used "DONTMATTER" 7 - If not logged out, click to 'Return to account summary' 8 - You are asked to sign in again 9 - Repeat with the SCI module 10 - Apply patch 11 - Repeat, but this time you can return to account Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163358|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164592&action=edit Bug 23102: Selenium test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164591|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164593&action=edit Bug 23102: 404 errors on page causes SCI user to be logged out To test: 1 - Have something on the SCO page that won't load Add to SCOUserJS: </script> <img src="http://localhost:8080/silk/famfamfam.png"/> <script> 2 - Enable the SCO and SCI system preferences: WebBasedSelfCheck: Enable SelfCheckInModuke: Enable AutoSelfCheckAllowed: Allow AutoSelfCheckID / AutoSelfCheckPass to a valid user with permissions 3 - Add the self_checkin_module and self_checkout_module permissions to the AutoSelfCheck user 4 - Access the selfcheckout module https://yoursite.org/cgi-bin/koha/sco/sco-main.pl 5 - Sign in using a patron 6 - Enter an unkown barcode, I used "DONTMATTER" 7 - If not logged out, click to 'Return to account summary' 8 - You are asked to sign in again 9 - Repeat with the SCI module 10 - Apply patch 11 - Repeat, but this time you can return to account Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Clear fix, well tested.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but the unit test is failing for me :( Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/selenium/regressions.t KO! # Failed test at /kohadevbox/koha/t/db_dependent/selenium/regressions.t line 87. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 125. # 'An error has occurred › Koha online catalog' # doesn't match '(?^u:Self check-in)' # Looks like you failed 1 test of 1. # Failed test 'SCI can load error pages' # at /kohadevbox/koha/t/db_dependent/selenium/regressions.t line 92. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. Wide character in print at /usr/share/perl/5.32/Test2/Formatter/TAP.pm line 156. # Looks like you failed 1 test of 9. /kohadevbox/koha/t/db_dependent/selenium/regressions.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/9 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/selenium/regressions.t (Wstat: 256 Tests: 9 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=9, 38 wallclock secs ( 0.02 usr 0.01 sys + 2.99 cusr 0.52 csys = 3.54 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- THis did initially fail - after a rest_all it worked fine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164819&action=edit Bug 23102: No mock in selenium -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- I worked with Katrin on this one and got tests passing, it was pushed to main, updating here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #46 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #47 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org