[Bug 18172] New: Logged in user page shows internal server error if OverDriveCirculation is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Bug ID: 18172 Summary: Logged in user page shows internal server error if OverDriveCirculation is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: liz@catalyst.net.nz Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Status: Needs Signoff Status: ASSIGNED Assignee: liz@catalyst.net.nz Patch complexity: Trivial patch It looks like the Overdrive js and one of the Overdrive divs are being shown in the OPAC logged in user page when overdrive is disabled. This causes an error in the log, and displays a message on the logged in user screen where Overdrive is supposed to put whatever it's getting from the API. This is in the log: OverDriveClientKey pref not set at /home/vagrant/kohaclone/opac/svc/overdrive line 38. --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- I have a patch for this but I can't seem to attach it, seems the server is out of space. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 60739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60739&action=edit Bug 18172 - Disabled Overdrive shows error on logged in user page To test: Have overdrive disabled (default state) log into the OPAC (I did it with plack) note the error just below the tabs on the page. Note that the overdrive JS is being fetched/included Apply this patch Restart plack/memcached refresh the page, note that the error is gone. Also note that the JS for Overdrive is no longer being fetched/included. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60739|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Comment on attachment 60739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60739 Bug 18172 - Disabled Overdrive shows error on logged in user page oops, something snuck in that shouldn't be there. Try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 60740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60740&action=edit Bug 18172 - Disabled Overdrive shows error on logged in user page To test: Have overdrive disabled (default state) log into the OPAC (I did it with plack) note the error just below the tabs on the page. Note that the overdrive JS is being fetched/included Apply this patch Restart plack/memcached refresh the page, note that the error is gone. Also note that the JS for Overdrive is no longer being fetched/included. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Marc Véron <veron@veron.ch> --- Sorry, patch does not apply (merge conflict in opac-user.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20686 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org